Bug 1551279
Summary: | authselect pulls in a LOT of extra dependencies than authconfig | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
Component: | authselect | Assignee: | Pavel Březina <pbrezina> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 28 | CC: | awilliam, gmarr, herrold, mattdm, pbrezina, sgallagh |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AcceptedFreezeException | ||
Fixed In Version: | authselect-0.3.2-1.fc28 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-03-26 22:28:50 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1269538, 496977, 661442, 1469205 |
Description
Peter Robinson
2018-03-04 11:32:10 UTC
It installs this as part of authselect-compat weak dependency (Recommends), I think it would be fine to use Suggests instead as we do in authselect package. authselect-0.3.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a9853e65a1 authselect-0.3.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a9853e65a1 Proposing as a freeze exception for Beta, avoiding this bloat in minimal images seems worthwhile. I took a look at the changes to the dependencies that were made in 0.3.1 and 0.3.2 and I think they're wrong. Suggests: dependencies are useless in this context; there is no UI in DNF or PackageKit to actually provide feedback to the user. The use of Recommends: was, in fact, the correct behavior. Recommends: essentially means "we think a default install of this package should require this, but in limited situations they could function without it." Suggests: is actually only used when the depsolver needs to resolve two different packages that can both satisfy a virtual dependency and when neither is already part of the transaction or currently-installed set. So having them here is completely non-functional. So either these weak dependencies should be left as Recommends: (because you think the average user of the system should have them if they install authselect), or they should be removed entirely.[*] Peter, I think what you are looking for in minimal images would have been already satisfied by `dnf --setopt=install_weak_deps=False upgrade realmd`. That usage of DNF really is how it should always be invoked in minimal environments. [*] A future enhancement could be for authselect to do as realmd does and automatically install the necessary packages based on the auth mechanism the user has selected. "The use of Recommends: was, in fact, the correct behavior. Recommends: essentially means "we think a default install of this package should require this, but in limited situations they could function without it."" I'm not sure I agree this is correct, at least in context. The typical case in Fedora is not *really* going to be "the user chooses to install authselect", after all. In practice, it's just going to get installed as part of initial system install, or on upgrade of an existing install, as in Peter's example. And we really don't want it to pull in all this stuff to minimal installs in that case, I don't think. I don't expect to do a 'minimal' install of Fedora from the network install image and have all that stuff pulled in. (In reply to Adam Williamson from comment #6) > "The use of Recommends: was, in fact, the correct behavior. Recommends: > essentially means "we think a default install of this package should require > this, but in limited situations they could function without it."" > Oops; I was typing in stream-of-consciousness and meant to go back and change this line. It should have read more like "Recommends: was closer to the correct behavior, in that it essentially means "we think a default install of this package should require this, but in limited situations they could function without it." However, looking closer into the actual way that authselect seems to work, I think the final, more correct approach would be to drop these dependencies *entirely*. Making them Suggests: doesn't result in them ever being pulled in anyway (and just grows the repodata). Discussed during the 2018-03-26 blocker review meeting: [1] The decision to classify this bug as an AcceptedFreezeException was made as it's desirable to remove the unwanted bits from the images that this addresses. [1] https://meetbot.fedoraproject.org/fedora-blocker-review/2018-03-26/f28-blocker-review.2018-03-26-16.01.txt authselect-0.3.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |