Bug 1551402 (falkon)

This is the browser formerly known as QupZilla. It was renamed to Falkon and the build system was changed from QMake to CMake, which is why this is not a simple rename review.

At this time, Falkon is considered a new browser that can coexist with the original QupZilla. There is currently no attempt at migrating existing users using Obsoletes/Provides nor at reading or migrating existing configuration files, profiles, and KWallet passwords from QupZilla.

Successful scratch build for Rawhide here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25487176

Taking this review.

Initial spec review notes:

> %{cmake_kf5} ..

We don't typically do braces around command macros. It doesn't hurt it in this case (since it's not parameterized), but in the future, avoid this, as command macros may be parameterized and this wouldn't work as intended

> %post
> /sbin/ldconfig
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>
> %postun
> /sbin/ldconfig
> if [ $1 -eq 0 ] ; then
>     touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>     gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
>
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

Drop all the scriptlets here and replace with %ldconfig_scriptlets.

The icon cache scriptlets has been replaced with a file trigger since Fedora 26, and the ldconfig execution should be using %ldconfig_scriptlets as it should be a no-op on F28+ and will work properly for <F28.

Fixed these:

Spec URL: https://repo.calcforge.org/fedora-review/falkon.spec
SRPM URL: https://repo.calcforge.org/fedora-review/falkon-3.0.0-2.fc29.src.rpm

* Mon Mar 05 2018 Kevin Kofler <Kevin.org> - 3.0.0-2
- don't use braces for the cmake_kf5 command macro
- remove obsolete scriptlets, add ldconfig_scriptlets transitional macro for now

Successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25501009

Ping? Can we move forward with this?

Apologizes, I had issues trying to get it to build locally. I managed to do this now, so I'm working on the review as we speak.

Apologies, I had issues trying to get it to build locally. I managed to do this now, so I'm working on the review as we speak.

Review notes:

+ Package builds and installs successfully
+ Package follows guidelines on naming
+ Licensing is appropriately marked and license files are correctly installed
+ Macros are correctly and consistently used
+ Patches are well documented
+ Handling of desktop files and AppStream data is per guidelines

! Ownership of icon file directories is not known ambiguous due to lack of "Requires: hicolor-icon-theme".

However, the one issue is minor, and historically we've not directly mandated it.

I'd appreciate if the Requires was added on import, but I'm not going to block this review any further.

PACKAGE APPROVED.

I always add that "Requires: hicolor-icon-theme" when I package a GUI app from scratch, it's missing here because this is based on the old qupzilla.spec, I will fix that.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/falkon

> ! Ownership of icon file directories is not known ambiguous due to lack of
> "Requires: hicolor-icon-theme".

Fixed:

* Sun Mar 25 2018 Kevin Kofler <Kevin.org> - 3.0.0-3
- add Requires: hicolor-icon-theme for directory ownership
- add obsolete_qupzilla flag to Obsolete/Provide qupzilla, enable it on F28+

https://src.fedoraproject.org/cgit/rpms/falkon.git/commit/?id=7f6f0bc5acfbecdbcdd444b389a668c5f432b2c7

falkon-3.0.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-53e38ed770

falkon-3.0.0-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-53e38ed770

falkon-3.0.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Is there a chance to package Falkon for Fedora 27 as well?

Maybe with 3.0.1, when the configuration migration will be in place. For 3.0.0, no, because it does not migrate configuration from QupZilla.

What I want to do is to push QupZilla 2.2.6, the final release of QupZilla, which has the features from Falkon 3.0.0 backported.

I filed updates with QupZilla 2.2.6:
F27: https://bodhi.fedoraproject.org/updates/FEDORA-2018-46b0560ccc
F26: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f9e35683fa
Functionality-wise, they should be more or less equivalent to Falkon 3.0.0.