Bug 1551603

Cloning, after Bz reproduced again in OSP13. 

Environment: 
------------
[stack@undercloud75 ~]$ rpm -qa | grep rhosp-director-images
rhosp-director-images-ipa-13.0-20180302.1.el7ost.noarch
rhosp-director-images-13.0-20180302.1.el7ost.noarch
openstack-tripleo-heat-templates-8.0.0-0.20180227121938.e0f59ee.el7ost.noarch



stack@undercloud75 ~]$ ssh heat-admin.0.11
The authenticity of host '192.168.0.11 (192.168.0.11)' can't be established.
ECDSA key fingerprint is SHA256:wQ+dLwaTklIrk0vYtTOcDQg/C8MpmIQ8xrCwk2R8i+U.
ECDSA key fingerprint is MD5:f1:a3:20:da:a6:65:05:db:f8:1f:14:86:a5:35:a2:dd.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.0.11' (ECDSA) to the list of known hosts.
[heat-admin@overcloud-controller-1 ~]$ sudo cat /etc/machine-id
b9270d3f95c6be35104f175dd46e8486
[heat-admin@overcloud-controller-1 ~]$ exit
logout
Connection to 192.168.0.11 closed.
[stack@undercloud75 ~]$ ssh heat-admin.0.8
Last login: Sat Mar  3 18:19:55 2018 from gateway
[heat-admin@overcloud-cephstorage-2 ~]$ sudo su -
[root@overcloud-cephstorage-2 ~]# cat /etc/machine-id
b9270d3f95c6be35104f175dd46e8486





----------------------------------------------------------------------------
+++ This bug was initially created as a clone of Bug #1476612 +++

Description of problem:
/etc/machine-id is the same on all overcloud nodes  (well the base RHEL 7.x image) so in a case where we're validating /etc/machine-id to be unique, it would create a conflict and only one node could be added (RHCS let's say).   I'm hesitating between creating a BZ for cloud-init or heat-templates to adress this. 

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Deploy an overcloud
2.
3.

Actual results:
They all have the same /etc/machine-id value

Expected results:
Should be different somehow

Additional info:

--- Additional comment from David Hill on 2017-07-30 14:20:59 EDT ---

(undercloud) [stack@undercloud-0-trunk ~]$ cat /etc/machine-id 
c9b62f7bee8b444da86ee1bc26aa7e72
(undercloud) [stack@undercloud-0-trunk ~]$ ssh heat-admin.2.9
The authenticity of host '192.0.2.9 (192.0.2.9)' can't be established.
ECDSA key fingerprint is d8:29:01:55:ef:7e:c7:29:08:d2:c0:fa:7e:28:9f:28.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.0.2.9' (ECDSA) to the list of known hosts.
[heat-admin@overcloud-controller-0 ~]$ cat /etc/machine-id 
c9b62f7bee8b444da86ee1bc26aa7e72



This could also be fixed in the image builder tool by deleting that file and creating it if it's missing on first boot.

--- Additional comment from Alex Schultz on 2017-07-31 09:05:36 EDT ---

This was fixed in Ocata as part of Bug 1270860. We would need to backport the appropriate changes.

--- Additional comment from David Hill on 2017-07-31 09:27:36 EDT ---

Is it fixed?  I clicked one of the openstack gerrit and the changes were abandonned.  Also , deleting it will prevent the system from starting properly but setting it as an empty file should work.

--- Additional comment from Alex Schultz on 2017-07-31 11:26:33 EDT ---

Correct, the two abandoned reviews were for fixes to DIB which were rejected. The first to listed on that bug were merged which were tripleo specific fixes for this issue. It's not a problem from 11+. We would have to backport for 10 and make sure images are rebuilt for 10.

https://review.openstack.org/#/c/445174/
https://review.openstack.org/#/c/445173/

--- Additional comment from Alex Schultz on 2017-07-31 14:08:59 EDT ---

Well I just verified that the file is still there. So I guess it needs further investigation.

--- Additional comment from David Hill on 2017-08-06 18:29:57 EDT ---

In 11, it'll be a problem if we only do a "rm -rf /etc/machine-id"... we must recreate it afterwards with "touch /etc/machine-id" !   We can probably abandon my change if we take this one.

--- Additional comment from David Hill on 2017-08-06 18:30:42 EDT ---

https://review.openstack.org/#/c/489013/

--- Additional comment from David Hill on 2017-08-06 18:33:51 EDT ---

This needs to be changed :
https://review.openstack.org/#/c/445173/1/elements/remove-machine-id/post-install.d/70-remove-machine-id

--- Additional comment from David Hill on 2017-08-06 18:35:46 EDT ---

Let me test this in Ocata and confirm if it's removing /etc/machine-id

--- Additional comment from Alex Schultz on 2017-08-07 11:46:36 EDT ---

So we'll fix this for tripleo via a backport of the previously mentioned items. https://review.openstack.org/#/c/489618/ is required to make it work for tripleo at the moment. We won't backport any work for disk image builder if that gets merged.

--- Additional comment from Lon Hohberger on 2017-11-16 16:05:33 EST ---

According to our records, this should be resolved by openstack-tripleo-puppet-elements-5.3.2-1.el7ost.  This build is available now.

--- Additional comment from Lon Hohberger on 2017-11-16 16:05:39 EST ---

According to our records, this should be resolved by openstack-tripleo-common-5.4.4-1.el7ost.  This build is available now.

--- Additional comment from Lon Hohberger on 2017-11-16 16:05:45 EST ---

According to our records, this should be resolved by rhosp-director-images-10.0-20171108.1.el7ost.  This build is available now.

--- Additional comment from Gurenko Alex on 2017-12-13 06:17:41 EST ---

Verified on build 2017-12-05.1 with RHEL 7.4 and rhosp-director-images-10.0-20171204.1.el7ost