Bug 1552540

Summary: Webadmin- misleading error appears trying to extend a disk with MaxBlockDiskSize (8192G) with a value of 1 or more
Product: [oVirt] ovirt-engine Reporter: Avihai <aefrat>
Component: BLL.StorageAssignee: Pavel Bar <pbar>
Status: CLOSED CURRENTRELEASE QA Contact: Avihai <aefrat>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.2CC: bugs, frolland, tnisan
Target Milestone: ovirt-4.3.3Keywords: EasyFix, StudentProject
Target Release: ---Flags: rule-engine: ovirt-4.3+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.3.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-16 13:58:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Print screens of the issue none

Description Avihai 2018-03-07 10:09:25 UTC
Created attachment 1405222 [details]
Print screens of the issue

Description of problem:
Via Webadmin try to extend a disk with MaxBlockDiskSize (8192G), 
'Extend size by(GB)' matching input box goes red & if you hover with the mouse over it you will see the following error message:

"This field must contain an integer number less than or equal to 0 " 
( see print screen attached.)

This error is misleading as actually, the disk is already in its max size so there should not be a possibility to extend it further.

Please fix the error to something clear like "Maximum size of disk already reached, cannot extend it further" or block the possibility to extend the disk once MaxBlockDiskSize is reached.

Version-Release number of selected component (if applicable):
4.2.2.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Create a disk(block SD) with MaxBlockDiskSize (8192G) & attach it to a VM1
2. Via VM1 window edit the disk & try to extend it by 1G -> 'Extend size by(GB)' goes red & if you hover with the mouse over it you will see an error message.


Actual results:
The following error message appears :

"This field must contain an integer number less than or equal to 0 " ( see print screen attached.

This error is misleading as actually, the disk is already in its max size so there should not be a possibility to extend it further.

Expected results:
Please either:
- fix the error to something clear like "Maximum size of disk already reached, cannot extend it further" 
 
 or:

- block the possibility to extend the disk once MaxBlockDiskSize is reached.

Additional info:
Print screen attached

Comment 1 Sandro Bonazzola 2019-01-28 09:34:42 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 2 Avihai 2019-03-31 11:47:08 UTC
Verified at ovirt-engine 4.3.3.1-0.1.el7.

Comment 3 Sandro Bonazzola 2019-04-16 13:58:29 UTC
This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.