Bug 1552843

Summary: cp -alx fails on lorax tree due to /etc/machine-id being on a different fs
Product: [Fedora] Fedora Reporter: Kevin Fenzi <kevin>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, dustymabe, kevin, lnykryn, msekleta, robatino, ssahani, s, systemd-maint, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedBlocker
Fixed In Version: systemd-238-3.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-08 17:48:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1469204    

Description Kevin Fenzi 2018-03-07 20:31:51 UTC
Rawhide composes as of 2018-03-06 are breaking because creating the boot.iso's are failing. lorax tries to do a 'cp -alx' to copy the installroot it just made to a backup copy, however the cp fails with a exit code of 1 because: 

/bin/cp: cannot create hard link '/var/tmp/lorax.yeti7uta/installroot/etc/machine-id' to '/var/tmp/lorax.yeti7uta/installtree/etc/machine-id': Invalid cross-device link

Looking in the chroot for the failed task I can copy/hardlink that file fine, but I suspect it's created as /run/machine-id and bind mounted to /etc/machine-id then somehow commited to the file. 

Note that this worked with previous systemd versions, systemd-238-2.fc29 is the one failing with this. 

Perhaps in systemd %post we need a:

systemd-machine-id-setup --commit

afer the systemd-machine-id-setup ?

Or perhaps this is some other change in the latest systemd and /etc/machine-id handling?

Comment 1 Fedora Update System 2018-03-08 15:54:38 UTC
systemd-238-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-721e8bd8d0

Comment 2 Fedora Update System 2018-03-08 15:55:05 UTC
systemd-238-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-721e8bd8d0

Comment 3 Fedora Blocker Bugs Application 2018-03-08 17:44:07 UTC
Proposed as a Blocker for 28-beta by Fedora user kevin using the blocker tracking app because:

  Bugs which entirely prevent the composition of one or more of the non-release-blocking images required to be built for a currently-pending (pre-)release

This bug prevents the compose from completing because it breaks the boot.iso creation.

Comment 4 Adam Williamson (Red Hat non-Fedora) 2018-03-08 17:45:15 UTC
Doesn't need to be proposed, it's an automatic blocker:

"Bugs which entirely prevent the composition of one or more of the release-blocking images required to be built for a currently-pending (pre-)release"

https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process#Automatic_blockers

PROCESS JUDO BLACK BELT POWER

Comment 5 Fedora Update System 2018-03-08 17:48:59 UTC
systemd-238-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.