Bug 1553113

Summary: backport fix for wrongly blocking autoconnect after no-secrets
Product: Red Hat Enterprise Linux 7 Reporter: Thomas Haller <thaller>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: atragler, bgalvani, fgiudici, fpokryvk, lmiksik, lrintel, rkhan, sukulkar, thaller, tpelka, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.12.0-0.1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:11:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Haller 2018-03-08 10:44:31 UTC
Backport of upstream fix https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=d2f019409d0906814ccd2050ce39609903f879f7

https://bugzilla.gnome.org/show_bug.cgi?id=794014


The condition when we would block autoconnect due to no-secrets was inverted. So, we would only block auto-connect, if a new agent registered (since the last secret request). That is an unlikely situation, so commonly we would not block autoconnect although we should, and in the unlikely situation (where a secret-agent registered in the meantime), we would wrongly block autoconnect.

Maybe the situation is not that unlikely after all, because we now do WPS by default, which extends the secret request for an unusually long time -- giving more chance for a secret agent to register while we are requesting the secret.

Comment 9 errata-xmlrpc 2018-10-30 11:11:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3207