Bug 1553353

Summary:	Allow CSS customization on CFME appliances
Product:	Red Hat CloudForms Management Engine	Reporter:	Andrea Perotti <aperotti>
Component:	UI - OPS	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jaroslav Henner <jhenner>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.9.0	CC:	amotta, cpelland, dhalasz, fpezzell, hkataria, ikaur, lavenel, mpovolny, niroy, obarenbo, rmanes, simaishi, smallamp
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.10.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1553841 (view as bug list)		Environment:
Last Closed:	2019-02-11 14:00:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1553841

Description Andrea Perotti 2018-03-08 18:06:28 UTC

Description of problem:

Up to CFME 4.5 it was possible to customize the UI and then rebuild it via:

vmdb && bundle exec rake assets:clean
vmdb && bundle exec rake assets:precompile

now with latest CFME 4.6 that sequence is not working anymore and this is affecting the ability to also apply small cosmetic changes to the appliance

Version-Release number of selected component (if applicable):
CFME 4.6.0

How reproducible:
Always

Actual results:
Impossibility to apply even minimal changes to css and to have those included into the UI

Expected results:
Offer the possibility to apply some customization to the css in order to present a more customized UX, needed for offering a branded experience to our customer's customers

Comment 6 CFME Bot 2018-03-09 12:31:04 UTC

https://github.com/ManageIQ/manageiq/pull/17127

Comment 7 CFME Bot 2018-03-09 12:32:23 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/3556

Comment 8 CFME Bot 2018-03-09 16:02:38 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/65cd2e2e1dfe7c971eeb46a4c9e04a9b2f401230
commit 65cd2e2e1dfe7c971eeb46a4c9e04a9b2f401230
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Mar  9 07:21:29 2018 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Mar  9 07:21:29 2018 -0500

    Load the custom.css that bypasses the asset pipeline on every screen

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1553353

 app/views/dashboard/saml_login.html.haml | 1 +
 app/views/layouts/application.html.haml | 1 +
 app/views/layouts/login.html.haml | 1 +
 app/views/layouts/remote_console.html.haml | 1 +
 app/views/layouts/report_only.html.haml | 1 +
 5 files changed, 5 insertions(+)

Comment 9 CFME Bot 2018-03-09 16:06:49 UTC

New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/fb34b613b0b37a3cf5aff0f730a6b37de4553590
commit fb34b613b0b37a3cf5aff0f730a6b37de4553590
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Mar  9 07:12:12 2018 -0500
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Mar  9 07:12:12 2018 -0500

    Create an empty CSS file that is outside the asset pipeline

    https://bugzilla.redhat.com/show_bug.cgi?id=1553353

 public/custom.css | 3 +
 1 file changed, 3 insertions(+)

Comment 12 Josh Carter 2018-07-19 14:41:39 UTC

*** Bug 1388936 has been marked as a duplicate of this bug. ***