Bug 1553595
| Summary: | Vlan over bond device cannot be shown after installation finished | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | jiachen zhang <jiaczhan> | |
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | high | |||
| Version: | 7.5 | CC: | atragler, bgalvani, cshao, dbragalo, dfediuck, fgiudici, huzhao, kazen, lrintel, mtessun, nanda_kishore_chinna, ptalbert, qiyuan, rbarry, rkhan, rvykydal, sbonazzo, sbueno, sukulkar, thaller, toneata, vbenes, weiwang, yaniwang, ycui, ylavi, yturgema | |
| Target Milestone: | pre-dev-freeze | Keywords: | ZStream | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | NetworkManager-1.10.2-14.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1570521 (view as bug list) | Environment: | ||
| Last Closed: | 2018-10-30 11:11:28 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1447254, 1507957, 1526256, 1570521 | |||
| Attachments: | ||||
Samantha, any changes in 7.5 you know of which would have caused this? Jiachen: is ONBOOT set to YES? The ONBOOT set to YES. (In reply to Ryan Barry from comment #1) > Samantha, any changes in 7.5 you know of which would have caused this? There should not be any, so if it is a regression I'd look at NetworkManager (1.8 in RHEL 7.4 -> 1.10 in RHEL 7.5). (In reply to jiachen zhang from comment #0) > Actual results: > 1. There is no vlan device shown in the results of `ip addr` > 2. There is ifcfg-VLAN-connection-1 under /etc/sysconfig/network-scripts/, > but DEVICE parameter is missing. Do you think it is the cause the problem? As of now, if you want to set DEVICE in ifcfg file you have to specify "VLAN" -> "VLAN Interface Name" in NetworkManager connection editor (used by Anaconda GUI) And I've checked that this doesn't seem to be changed between 7.4 (NM 1.8) and 7.5 (NM 1.10). I am reassigning to NetworkManager for comments. Created attachment 1407102 [details]
log containing NM messages from installation
> 3.After installation finished, check ip with `ip addr` "After installation" here means on first boot into the newly installed system? > 2. Reboot the host again, vlan device still cannot be shown. Can you please enable level=TRACE debug level (see https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/contrib/fedora/rpm/NetworkManager.conf). Then reboot, and provide the full log. Created attachment 1407413 [details]
The updated attachment of "/var/log"
(In reply to Thomas Haller from comment #6) > > 3.After installation finished, check ip with `ip addr` > > "After installation" here means on first boot into the newly installed > system? > > Yes. > > > 2. Reboot the host again, vlan device still cannot be shown. > > Can you please enable level=TRACE debug level (see > https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/contrib/ > fedora/rpm/NetworkManager.conf). > Then reboot, and provide the full log. > > Please see the lastest attachment. (In reply to jiachen zhang from comment #7) > Created attachment 1407413 [details] > The updated attachment of "/var/log" Thank you, but the attached logfile contains no debug logging. Please configure level=TRACE in /etc/NetworkManager/NetworkManager.conf before reboot. See comment 6. Ryan can we have a workaround in RHV-H while platform fixes this? According bug's description: 1. Restart NetworkManager can bring the vlan device up. 2. Reboot the host again, vlan device still cannot be shown. Created attachment 1407568 [details]
NetworkManager.log
(In reply to Thomas Haller from comment #9) > (In reply to jiachen zhang from comment #7) > > Created attachment 1407413 [details] > > The updated attachment of "/var/log" > > Thank you, but the attached logfile contains no debug logging. Please > configure level=TRACE in /etc/NetworkManager/NetworkManager.conf before > reboot. See comment 6. I generated NetworkManager.log using `journalctl -u NetworkManager.service > NetworkManager.log`, and there are trace info in it. I wonder if this is what you need, please check the attachment. We do not have a workaround for this, and I'm not sure if one is possible without trying to completely reimplement NM's logic in imgbased (In reply to Qin Yuan from comment #13) > I generated NetworkManager.log using `journalctl -u NetworkManager.service > > NetworkManager.log`, and there are trace info in it. I wonder if this is > what you need, please check the attachment. This is fine. Thank you!! I think the regression is caused by this commit: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ed640f857a1a1eae45d92cce35ea8dcfd8aba08d During startup we look for a parent for the vlan connection and the bond is skipped because still unmanaged (by platform); therefore the activation fails with: manager: (VLAN connection 1) can't get a name of a virtual device: failed to determine interface name: error determine name for vlan The same issues occurs in redhat-virtualization-host-4.1-20180307.0 Created attachment 1410448 [details]
[PATCH] manager: retry activating devices when the parent becomes managed
(In reply to Beniamino Galvani from comment #20) > Created attachment 1410448 [details] > [PATCH] manager: retry activating devices when the parent becomes managed lgtm. Does it pass CI? (In reply to Thomas Haller from comment #21) > (In reply to Beniamino Galvani from comment #20) > > Created attachment 1410448 [details] > > [PATCH] manager: retry activating devices when the parent becomes managed > > lgtm. Does it pass CI? Yes, it does. CI test for this scenario: https://github.com/NetworkManager/NetworkManager-ci/pull/162 Patch applied to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit /?id=6493bd443f6c1d089919f0bb63c735bc2a76fc75 and nm-1-10. Just to verify - This is picked to nm-1.10. Are we planning to ship this with 7.5 (which currently uses 1.10)? (In reply to Ryan Barry from comment #26) > Just to verify - > > This is picked to nm-1.10. Are we planning to ship this with 7.5 (which > currently uses 1.10)? It's too late for 7.5 GA, but we can ship the fix in the first z-stream batch. This is critical to RHV 4.2 GA. Adding blocker flag. According to comment 19, this is critical to RHVH 4.1.10 async el7.5 release. Test this bug with the version redhat-virtualization-host-4.2-20180507.0 I configured Bond+Vlan and reboot successfully and the bond+vlan can be shown. *** Bug 1576506 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3207 |
Created attachment 1406158 [details] /var/log /tmp ifcfg Description of problem: Install RHVH-4.2-20180305.0-RHVH-x86_64-dvd1.iso via Anaconda GUI, configure a vlan device over a bond, after installation finished, the vlan device cannot be shown. Version-Release number of selected component (if applicable): RHVH-4.2-20180305.0-RHVH-x86_64-dvd1.iso How reproducible: 100% Steps to Reproduce: 1.Install RHVH-4.2-20180305.0-RHVH-x86_64-dvd1.iso via Anaconda GUI 2.Configure a vlan device over a bond 3.After installation finished, check ip with `ip addr` Actual results: 1. There is no vlan device shown in the results of `ip addr` 2. There is ifcfg-VLAN-connection-1 under /etc/sysconfig/network-scripts/, but DEVICE parameter is missing. Expected results: 1. The vlan over bond device could be shown, and can get IP Additional info: 1. Restart NetworkManager can bring the vlan device up. 2. Reboot the host again, vlan device still cannot be shown. 3. If only configure a vlan device, not over bond, then after installation finished, the vlan device can be shown with the right IP.