Bug 1553632

Summary: Review Request: perl-GooCanvas2 - Perl binding for GooCanvas2 widget using Glib::Object::Introspection
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-GooCanvas2-0.06-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-12 13:54:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1553142    

Description Petr Pisar 2018-03-09 08:46:41 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-GooCanvas2/perl-GooCanvas2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-GooCanvas2/perl-GooCanvas2-0.06-1.fc29.src.rpm
Description:
GooCanvas2 is a new canvas widget for use with Gtk3 that uses the Cairo
2-dimensional library for drawing. This is a Perl binding for this wonderful
Canvas widget.

Fedora Account System Username: ppisar
Comment 1 Robert-André Mauchin 🐧 2018-03-09 17:59:42 UTC 
URL and Source addresses are Ok.
Source archive (SHA-256: e24c87873e19063dd4d5e2c709caacf8c0ae8881044395bb865dc2b4fdd63b50) is original. Ok.
Summary verified from lib/GooCanvas2.pm. Ok.
Description verified from lib/GooCanvas2.pm. Ok.
License verified from lib/GooCanvas2.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-GooCanvas2.spec review-perl-GooCanvas2/results/perl-GooCanvas2-0.06-1.fc29.noarch.rpm review-perl-GooCanvas2/results/perl-GooCanvas2-0.06-1.fc29.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p perl-GooCanvas2-0.06-1.fc29.noarch.rpm        18:53:52
drwxr-xr-x    2 root    root                        0 mars  9 18:51 /usr/share/doc/perl-GooCanvas2
-rw-r--r--    1 root    root                      811 juin 19  2017 /usr/share/doc/perl-GooCanvas2/Changes
-rw-r--r--    1 root    root                      876 juin 18  2017 /usr/share/doc/perl-GooCanvas2/README
-rw-r--r--    1 root    root                     3229 mars  9 18:51 /usr/share/man/man3/GooCanvas2.3pm.gz
-rw-r--r--    1 root    root                     7283 juin 19  2017 /usr/share/perl5/vendor_perl/GooCanvas2.pm
File permissions and layout are Ok.

rpm -q --requires -p perl-GooCanvas2-0.06-1.fc29.noarch.rpm | sort -f | uniq -c
      1 goocanvas2 >= 2.0
      1 perl(:MODULE_COMPAT_5.26.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Glib::Object::Introspection)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-GooCanvas2-0.06-1.fc29.noarch.rpm 
perl(GooCanvas2) = 0.06
perl(GooCanvas2::Canvas) = 0.06
perl-GooCanvas2 = 0.06-1.fc29
Binary provides are Ok.

Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=25585468)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.
Comment 2 Gwyn Ciesla 2018-03-12 13:30:44 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GooCanvas2
Comment 3 Petr Pisar 2018-03-12 13:54:13 UTC 
Thank you for the review and the repository.