Bug 1553639 (rust-hyper)

Summary:	Review Request: rust-hyper - Modern HTTP library
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-20 10:44:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1553610, 1553635
Bug Blocks:

Description Igor Gnatenko 2018-03-09 09:10:32 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-hyper.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-hyper-0.11.22-1.fc29.src.rpm
Description:
Modern HTTP library.
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2018-03-09 20:41:29 UTC

Build error:

BUILDSTDERR:    Compiling tokio-core v0.1.12
BUILDSTDERR:      Running `/usr/bin/rustc --crate-name tokio_core /usr/share/cargo/registry/tokio-core-0.1.12/src/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=3 -C metadata=84504471d9c2cb31 -C extra-filename=-84504471d9c2cb31 --out-dir /builddir/build/BUILD/hyper-0.11.22/target/release/deps -L dependency=/builddir/build/BUILD/hyper-0.11.22/target/release/deps --extern log=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/liblog-129ea5bbac2dadda.rlib --extern futures=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libfutures-98f50b5ddb4b0aa3.rlib --extern slab=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libslab-b17f549fb7b4bc0c.rlib --extern bytes=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libbytes-e80650f556e05ce6.rlib --extern tokio_io=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libtokio_io-68b9f7afb436dc4a.rlib --extern iovec=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libiovec-e4757dc54099439a.rlib --extern mio=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libmio-015995e705c15631.rlib --extern scoped_tls=/builddir/build/BUILD/hyper-0.11.22/target/release/deps/libscoped_tls-7dc00805d71a4171.rlib --cap-lints allow -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:276:39
BUILDSTDERR:     |
BUILDSTDERR: 276 |         if let Async::NotReady = self.poll_read() {
BUILDSTDERR:     |                                       ^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:276:16
BUILDSTDERR:     |
BUILDSTDERR: 276 |         if let Async::NotReady = self.poll_read() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:289:39
BUILDSTDERR:     |
BUILDSTDERR: 289 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                                       ^^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:289:16
BUILDSTDERR:     |
BUILDSTDERR: 289 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:300:39
BUILDSTDERR:     |
BUILDSTDERR: 300 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                                       ^^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:300:16
BUILDSTDERR:     |
BUILDSTDERR: 300 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:335:39
BUILDSTDERR:     |
BUILDSTDERR: 335 |         if let Async::NotReady = self.poll_read() {
BUILDSTDERR:     |                                       ^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:335:16
BUILDSTDERR:     |
BUILDSTDERR: 335 |         if let Async::NotReady = self.poll_read() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:350:39
BUILDSTDERR:     |
BUILDSTDERR: 350 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                                       ^^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:350:16
BUILDSTDERR:     |
BUILDSTDERR: 350 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error[E0061]: this function takes 1 parameter but 0 parameters were supplied
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:361:39
BUILDSTDERR:     |
BUILDSTDERR: 361 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                                       ^^^^^^^^^^ expected 1 parameter
BUILDSTDERR: error[E0308]: mismatched types
BUILDSTDERR:    --> /usr/share/cargo/registry/tokio-core-0.1.12/src/reactor/poll_evented.rs:361:16
BUILDSTDERR:     |
BUILDSTDERR: 361 |         if let Async::NotReady = self.poll_write() {
BUILDSTDERR:     |                ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found enum `futures::Async`
BUILDSTDERR:     |
BUILDSTDERR:     = note: expected type `std::result::Result<futures::Async<usize>, std::io::Error>`
BUILDSTDERR:                found type `futures::Async<_>`
BUILDSTDERR: error: aborting due to 12 previous errors
BUILDSTDERR: error: Could not compile `tokio-core`.

Comment 2 Robert-André Mauchin 🐧 2018-03-09 21:36:04 UTC

Works fine with tokio-core v0.1.13 from bug #1553572. Maybe bump the minimal requirements?

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors

Package approved.

Comment 3 Igor Gnatenko 2018-03-10 00:52:22 UTC

(In reply to Robert-André Mauchin from comment #2)
> Works fine with tokio-core v0.1.13 from bug #1553572. Maybe bump the minimal
> requirements?

It's some regression in tokio, so it's tokio-core should bump requirements. I will sort it out.

Comment 4 Gwyn Ciesla 2018-03-12 13:11:52 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hyper