Bug 1553932

Summary:	Any REX ssh job leaves a new /var/tmp/foreman-ssh-cmd-* directory
Product:	Red Hat Satellite	Reporter:	Pavel Moravec <pmoravec>
Component:	Remote Execution	Assignee:	Dmitri Dolguikh <ddolguik>
Status:	CLOSED ERRATA	QA Contact:	Ales Dujicek <adujicek>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2.0	CC:	adujicek, aruzicka, bkearney, inecas, jquan, mlesieur, peter.vreman
Target Milestone:	6.4.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	tfm-rubygem-foreman_remote_execution-1.5.2-2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-16 19:34:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1122832

Description Pavel Moravec 2018-03-09 22:43:39 UTC

Description of problem:
Running a REX job with ssh default template leaves a small /var/tmp/foreman-ssh-cmd-* directory that is never deleted.

REX job should remove that dir once it finishes all other activity.

Per my understanding, all that information is also stored in postgres in task status, so deleting those dirs wont prevent investigation.


Version-Release number of selected component (if applicable):
Sat6.3.0


How reproducible:
100%


Steps to Reproduce:
1. Run a REX job with "Run Command - SSH Default through SSH" template (other templates might create similar dirs as well)
2. Check new dir under /var/tmp/ created


Actual results:
2. there is a new dir


Expected results:
2. there shouldnt be such a new dir


Additional info:

Comment 2 Peter Vreman 2018-03-16 10:22:29 UTC

This behaviour is there already since the start of REX in 6.2.x

See below that i have those files already createing since early 2017 when i started using REX:

---------------
$ ls -lt /var/tmp
total 140
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 21 08:06 foreman-ssh-cmd-721c579a-9c1d-49bf-b095-91ff5d10bea0
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 20 13:57 foreman-ssh-cmd-9d6b48dc-920b-404c-af92-e2e2ecc47b9a
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 20 13:02 foreman-ssh-cmd-a59b2e7d-fead-4205-8e52-602102fe3f55
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 20 10:13 foreman-ssh-cmd-56300a51-5ac5-4cf6-8a80-11e1d7cca464
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 20 09:27 foreman-ssh-cmd-85d418ae-e0f0-4517-ae75-0372b15fd0e8
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb  1 08:51 foreman-ssh-cmd-1336c644-ded2-4414-9fa9-7698626aa62c
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jan 31 11:24 foreman-ssh-cmd-3e38a0c2-8e57-4c4a-8d37-4b4951a74fa3
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jan 30 14:00 foreman-ssh-cmd-b4efbfa6-3e68-4fab-9b10-98eee85e348a
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jan 30 08:56 foreman-ssh-cmd-d6cbbcdf-231b-4b7e-ac03-70eb6e9e1aa3
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jan 29 14:42 foreman-ssh-cmd-74b4dcb9-109b-4755-9c74-11e84945730b
drwxrwxr-x. 2 hoirexec hoirexec 4096 Nov 27 11:18 foreman-ssh-cmd-0d030edd-d1ea-43d3-abac-57c7731b4bdd
drwxrwxr-x. 2 hoirexec hoirexec 4096 Nov  6 11:36 foreman-ssh-cmd-2195a0a4-4ae7-4e7c-88b5-38182c894fef
drwxrwxr-x. 2 hoirexec hoirexec 4096 Nov  2 10:41 foreman-ssh-cmd-4a356416-bcf8-4810-9b8c-80b08dc102fe
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 31 14:28 foreman-ssh-cmd-44de1357-b2e7-432a-b6a7-65f373655641
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 18 13:58 foreman-ssh-cmd-d098e524-0532-4842-83b8-fd7916f70566
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 18 13:20 foreman-ssh-cmd-bf360cc9-6765-4807-8024-872f325c7764
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 18 13:16 foreman-ssh-cmd-843ed7eb-7220-493d-bb16-8e937857b082
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 18 12:29 foreman-ssh-cmd-1706e784-afee-47fe-9578-0a9b7da8ccb2
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 18 12:21 foreman-ssh-cmd-b300526b-6a4b-41e3-b64d-85c457b9c3c7
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 16 17:22 foreman-ssh-cmd-03259705-3472-449f-8714-096d354329a5
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 13 14:03 foreman-ssh-cmd-9d4df7c3-8761-45ec-9a00-2442f6bbafea
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 13 13:43 foreman-ssh-cmd-36834b84-b47e-46c5-9dca-bcb33aa4df2c
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 13 13:06 foreman-ssh-cmd-1290d097-5c5a-49d3-b713-5137a04a0298
drwxrwxr-x. 2 hoirexec hoirexec 4096 Oct 13 13:05 foreman-ssh-cmd-f483ead6-b5df-4475-b3bd-9580e368bc00
drwxrwxr-x. 2 hoirexec hoirexec 4096 Aug 14  2017 foreman-ssh-cmd-7ece2cd7-a4f1-40e2-b5f1-5624b8cede60
drwxrwxr-x. 2 hoirexec hoirexec 4096 Aug  4  2017 foreman-ssh-cmd-16533d55-fb37-43ce-9648-81519b56632b
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jul 28  2017 foreman-ssh-cmd-3cc11f74-2e42-4017-801b-365a927f090a
drwxrwxr-x. 2 hoirexec hoirexec 4096 Jul 21  2017 foreman-ssh-cmd-ae45ac52-252e-47a8-a8fb-a16ff7a3c5fb
drwxrwxr-x. 2 hoirexec hoirexec 4096 Mar 17  2017 foreman-ssh-cmd-0422936a-b279-4af4-9eb0-b5fdd64ed9de
drwxrwxr-x. 2 hoirexec hoirexec 4096 Mar 17  2017 foreman-ssh-cmd-4e1301a2-62cd-4d2c-b571-d0854d1e4844
drwxrwxr-x. 2 hoirexec hoirexec 4096 Mar 17  2017 foreman-ssh-cmd-736a78c0-29f5-4aec-ba07-6a51d9ce516a
drwxrwxr-x. 2 hoirexec hoirexec 4096 Mar  6  2017 foreman-ssh-cmd-501f1021-aff2-4770-baad-2bc372266a00
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 18  2017 foreman-ssh-cmd-6bfac3b1-1432-4079-899c-45aaa48e1ddd
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb 15  2017 foreman-ssh-cmd-3096c008-9e77-416f-82f3-d0a87ac8281d
drwxrwxr-x. 2 hoirexec hoirexec 4096 Feb  3  2017 foreman-ssh-cmd-8ca3094b-e5c7-4bc3-a6a9-af40268b440b
---------------------

Comment 3 Pavel Moravec 2018-03-16 10:41:21 UTC

(In reply to Peter Vreman from comment #2)
> This behaviour is there already since the start of REX in 6.2.x

Indeed, and I think it has been always there, since the first REX implementation.

I filed the BZ against 6.3 only, since I think it is not severe enough to be fixed in 6.2.z.

Comment 5 Ivan Necas 2018-03-19 14:52:10 UTC

Setting the Version to 6.2, as that's not where it's decided which target release it would be fixed in (thanks Peter for pointing that out)

The initial motivation for keeping the scripts was to be able to investigate the artefacts of the scripts at the clients themselves, especially in cases that there would be some issue during transferring the data out of the remote host to the main postgres server. But I'm ok with keeping this behaviour only with some additional setting.

Comment 6 Ivan Necas 2018-03-19 14:54:41 UTC

Created redmine issue http://projects.theforeman.org/issues/22934 from this bug

Comment 7 Satellite Program 2018-03-28 20:13:36 UTC

Upstream bug assigned to ddolguik

Comment 8 Satellite Program 2018-03-28 20:13:42 UTC

Upstream bug assigned to ddolguik

Comment 9 Satellite Program 2018-05-03 10:13:12 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/22934 has been resolved.

Comment 12 Bryan Kearney 2018-10-16 19:34:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927