Bug 1554259

Summary: Service dialog name is displayed when the dialog is run
Product: Red Hat CloudForms Management Engine Reporter: Peter McGowan <pmcgowan>
Component: UI - OPSAssignee: Oleg Barenboim <obarenbo>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, hkataria, lavenel, mpovolny, obarenbo, simaishi, sshveta
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: service
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1559166 (view as bug list) Environment:
Last Closed: 2019-02-11 13:59:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1559166    
Attachments:
Description Flags
fixed_5.10.0.17.png none

Description Peter McGowan 2018-03-12 09:12:03 UTC 
Description of problem:
The dialog name is now prominently displayed at the top of a service dialog, whereas it wasn't displayed in versions of CloudForms prior to 4.6. This should not be displayed as the dialog name often has no relation to the name of the button or service catalog item that has been ordered, and displaying the name in this way will cause confusion. 

For example a single service dialog called "Generic VM Options" might be used to front the service catalog items for several VM types, by prompting for common elements such as VM name, VM size, service name etc. If the user has ordered a service called "Order a RHEL 7 VM", they shouldn't see a dialog called "Generic VM Options".

Version-Release number of selected component (if applicable):
5.9.0.22

How reproducible:
Every time


Steps to Reproduce:
1. Create a service dialog called "Generic dialog", and assign to a button
2. Click the button

Actual results:
Observe that the service dialog name "Generic dialog" is displayed 

Expected results:
The dialog name shouldn't be displayed when a button or service is ordered

Additional info:
Comment 3 Chris Hale 2018-03-13 20:54:40 UTC 
GH PR https://github.com/ManageIQ/ui-components/pull/269
Comment 5 Yadnyawalk Tale 2018-10-03 16:30:35 UTC 
Created attachment 1490180 [details]
fixed_5.10.0.17.png

Fixed! Checked with 4 following usecases:

1. By ordering dialogs via OPS UI
2. By ordering dialog via SSUI
3. By ordering dialog via Custom button
4. Importing 5.9.1 dialogs into 5.9.1.1

All four usecases *worked well* and dialog name not displyed anywhere in between.
Verified on: 5.10.0.17.20180927011235_1b5cf54

Thanks!