Bug 1554278

Summary:	fedpkg request-repo does not work
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	fedpkg	Assignee:	cqi
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	27	CC:	cqi, dennis, jkeating, lsedlar, mprahl, pbabinca, s
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-19 00:10:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2018-03-12 10:04:48 UTC

I believe "fedpkg request-repo" supersedes fedrepo-req, yet it fails.

Running from a non-dist-git directory:

$ fedpkg request-repo --description 'Gtk3 has a powerful, but complex MVC (Model, View, Controller) system used
to implement list and tree widgets. Gtk3::SimpleList Perl module automates the
complex setup work and allows you to treat the list model as a more natural
list of lists structure.' --monitor monitoring-with-scratch --upstreamurl 'http://search.cpan.org/dist/Gtk3-SimpleList/' 1553622
Failed to get module name from Git url or pushurl
Could not execute request_repo: /home/petr/fedora is not a valid repo

Why does it care about current working directory? I want to create a new repository. I do not work with an existing repository.

Running from a libisds dist-git directory:

$ fedpkg request-repo --description 'Gtk3 has a powerful, but complex MVC (Model, View, Controller) system used
to implement list and tree widgets. Gtk3::SimpleList Perl module automates the
complex setup work and allows you to treat the list model as a more natural
list of lists structure.' --monitor monitoring-with-scratch --upstreamurl 'http://search.cpan.org/dist/Gtk3-SimpleList/' 1553622
Could not execute request_repo: The package in the Bugzilla bug "perl-Gtk3-SimpleList" doesn't match the one provided "libisds"

It still does a wrong check.

"fedpkg request-repo" usage menitions --module-name option in an example, but I do want to create an RPM repository. Not a module one.

Something is broken in fedpkg-1.32-1.fc27.noarch.

Comment 1 cqi 2018-03-13 13:17:15 UTC

--module-name could be sort of ambiguous with the module build. But, it works as the help message says and it does not mean the modules introduced by Fedora Modularity. For command request-repo, --module-name is used to provide the repository name.

Regarding the second command, could you try again with specifying '--module-name perl-Gtk3-SimpleList'?

Comment 2 cqi 2018-03-13 13:21:36 UTC

FYI, I tried to create a ticket and it succeeded with this command inside another package repository,

fedpkg-stage --module-name perl-Gtk3-SimpleList request-repo --description 'Gtk3 has a powerful, but complex MVC (Model, View, Controller) system used to implement list and tree widgets. Gtk3::SimpleList Perl module automates the complex setup work and allows you to treat the list model as a more natural list of lists structure.' --monitor monitoring-with-scratch --upstreamurl 'http://search.cpan.org/dist/Gtk3-SimpleList/' 1553622

Ticket URL: https://stg.pagure.io/releng/fedora-scm-requests/issue/80

Comment 3 Petr Pisar 2018-03-13 14:57:04 UTC

I tried with the --module-name argument from libisds directory and it worked <https://pagure.io/releng/fedora-scm-requests/issue/4991>.

Would it be possible to rename the --module-name to --repository-name?

How can I differentiate between rpms and modules namespace (i.e. I want to create a repository for a Modularity module versus I want to create a repository for an RPM package). Can I use 'modules/foo' and 'rpms/foo'? Is the 'rpms/' prefix implicit? If so, then document it.

By the way the "fedpkg request-repo --help" usage shows:

  --monitor {no-monitoring,monitoring,monitoring-with-scratch}, -m {no-monitoring,monitoring,monitoring-with-scratch}
                        The Koshei monitoring type for the repo

I think this is about release-monitoring (anitya). Not about Koschei.

Comment 4 cqi 2018-03-15 13:59:39 UTC

(In reply to Petr Pisar from comment #3)
> I tried with the --module-name argument from libisds directory and it worked
> <https://pagure.io/releng/fedora-scm-requests/issue/4991>.
> 
> Would it be possible to rename the --module-name to --repository-name?
> 

There is a discussion thread in Fedora devel mailing list.

> How can I differentiate between rpms and modules namespace (i.e. I want to
> create a repository for a Modularity module versus I want to create a
> repository for an RPM package). Can I use 'modules/foo' and 'rpms/foo'? Is
> the 'rpms/' prefix implicit? If so, then document it.

rpms is default if no namespace is specified. Based on the discussion, there will be a change to deprecated --module-name and introduce new option(s) to replace it. The new options will be documented well.

> 
> By the way the "fedpkg request-repo --help" usage shows:
> 
>   --monitor {no-monitoring,monitoring,monitoring-with-scratch}, -m
> {no-monitoring,monitoring,monitoring-with-scratch}
>                         The Koshei monitoring type for the repo
> 
> I think this is about release-monitoring (anitya). Not about Koschei.

I'm not sure about this. @mprahl, any idea?

Comment 5 Matt Prahl 2018-03-15 14:22:06 UTC

@cqi that's right, it is Anitya and not Koshei. That was my mistake.

Comment 6 Matt Prahl 2018-03-15 14:27:03 UTC

I filed a PR to fix the naming mistake: https://pagure.io/fedpkg/pull-request/196

Comment 7 cqi 2018-03-15 15:14:40 UTC

Hi Petr, so far, do you mind to close this bug?

Comment 8 Petr Pisar 2018-03-15 15:25:52 UTC

I'm fine with closing this bug report.