Bug 1554935

Summary: Manila UI Package Does Not Include Required Configuration Files
Product: Red Hat OpenStack Reporter: Dustin Schoenbrun <dschoenb>
Component: openstack-manila-uiAssignee: Victoria Martinez de la Cruz <vimartin>
Status: CLOSED ERRATA QA Contact: Dustin Schoenbrun <dschoenb>
Severity: high Docs Contact:
Priority: urgent    
Version: 13.0 (Queens)CC: apevec, hguemar, joflynn, jschluet, lhh, rhos-maint, sclewis, vimartin
Target Milestone: z2Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)Flags: vimartin: needinfo+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-manila-ui-2.13.0-4.el7ost Doc Type: Bug Fix
Doc Text:
Configuration files for manila-ui plugin were not being copied. As a result, the manila panel did not show up on the dashboard. The instructions for copying all of the configuration files for manila-ui to the required locations are now present. The manila panel is visible when the user enables the dashboard.
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-29 16:32:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1578478    
Bug Blocks:    
Attachments:
Description Flags
ON_QA horizon check for manila plug-in not there
none
manila panel shares in the horizon panel none

Description Dustin Schoenbrun 2018-03-13 15:26:14 UTC
Description of problem:
With the containerization of Manila and Horizon, it appears that there is an issue with getting the configuration files required for changing the functionality of the Manila Horizon UI Plugin are not being included in the container running Horizon. This prevents the administrator from configuring the ability to enable or disable creating public shares, enabled share protocols, and other such UI options.

Version-Release number of selected component (if applicable):
openstack-manila-ui-2.13.1-0.20180220035500.51ce208.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Install OSP-13 ensuring that containerized deployment of all services is enabled.
2. Log in to the controller node running the Horizon container.
3. Navigate to where puppet puts the files that will be included in the containers that run on the controller node (/var/lib/config-data/puppet-generated)
4. Look in both the manila and openstack-dashboard directories and observe that relevant configuration file (namely _90_manila_admin_shares.py) is not present.
5. Log in to the Horizon container and observe that the relevant configuration file is not present in the /etc/openstack-dashboard directory.

Actual results:
There is no way to change the behavior of the Manila Horizon UI plugin to suit an administrator's needs.

Expected results:
The configuration files can be changed to modify the behavior of the Manila Horizon UI Plugin on the Horizon container's restart. 

Additional info:
This appears to be some sort of packaging bug where the files needed are not being put in the correct place to be included in the Horizon container when it is built and started. We may want to look at how Sahara provides the configuration options for its Horizon UI Plugin and model our approach after theirs.

Comment 12 Vince Green 2018-07-13 13:53:41 UTC
Dustin installed OSP13z1 with puddle 

14:09:31 Build mark: core_puddle=2018-07-11.1

When loading Horizon after porting 8080 to the undercloud, I still don't see the manila plugin loading.

On the horizon container, manila-ui version is

[heat-admin@controller-1 ~]$ sudo docker exec -t -i horizon /bin/bash
()[root@controller-1 /]# rpm -qa | grep manila
puppet-manila-12.4.0-0.20180329035214.6c18418.el7ost.noarch
python2-manilaclient-1.21.0-1.el7ost.noarch
openstack-manila-ui-2.13.0-3.el7ost.noarch

The package matches the fixed in version, so the issue still persists.

On closer inspection in the horizon container, the sym links in /etc/openstack-dashboard/enabled/ that point to /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/ are still broken (which means the files didn't get copied to that pointed directory, see below:

()[root@controller-2 enabled]# cd /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/
()[root@controller-2 enabled]# ls
_1482_project_load_balancer_panel.py   _1820_data_processing_clusters_panel.py   _1840_data_processing_jobs_panel.py   __init__.py
_1482_project_load_balancer_panel.pyc  _1820_data_processing_clusters_panel.pyc  _1840_data_processing_jobs_panel.pyc  __init__.pyc
_1810_data_processing_panel_group.py   _1830_data_processing_plugins_panel.py    _2200_ironic.py                       __init__.pyo
_1810_data_processing_panel_group.pyc  _1830_data_processing_plugins_panel.pyc   _2200_ironic.pyc

Moving bug back to ON_DEV.  Will attach picture of horizon.

Comment 13 Vince Green 2018-07-13 13:54:38 UTC
Created attachment 1458735 [details]
ON_QA horizon check for manila plug-in not there

Comment 14 Victoria Martinez de la Cruz 2018-07-20 18:56:50 UTC
*** Bug 1578478 has been marked as a duplicate of this bug. ***

Comment 20 Vince Green 2018-07-31 18:52:38 UTC
Ran with puddle=2018-07-30.2 for a jenkins deployment on osp13.  The manila-ui plugin tab shares comes up in horizon, so this verifies the fix, openstack-manila-ui-2.13.0-4.el7ost, was in the downstream.

Looking in the horizon container, the sym links that were initially broken for the plugin are now pointing to existing files as shown in a fixed version of contianerized osp12.

[heat-admin@controller-0 ~]$ sudo docker ps | grep horizon
25ba75105392        192.168.24.1:8787/rhosp13/openstack-horizon:2018-07-30.2                     "kolla_start"            3 hours ago         Up 3 hours                                   horizon

[heat-admin@controller-0 ~]$ sudo docker exec -t -i horizon /bin/bash
()[root@controller-0 /]# rpm -qa | grep manila
puppet-manila-12.4.0-2.el7ost.noarch
openstack-manila-ui-2.13.0-5.el7ost.noarch
python2-manilaclient-1.21.0-1.el7ost.noarch

()[root@controller-0 /]# ls -l /etc/openstack-dashboard/enabled/
total 12
lrwxrwxrwx. 1 horizon horizon  101 Jul 30 13:39 _1810_data_processing_panel_group.py -> /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1810_data_processing_panel_group.py
lrwxrwxrwx. 1 horizon horizon  102 Jul 30 13:39 _1810_data_processing_panel_group.pyc -> /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1810_data_processing_panel_group.pyc
lrwxrwxrwx. 1 horizon horizon  104 Jul 30 13:39 _1820_data_processing_clusters_panel.py -> /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/_1820_data_processing_clusters_panel.py

Marking bug as verified.

Comment 21 Vince Green 2018-07-31 18:53:42 UTC
Created attachment 1471907 [details]
manila panel shares in the horizon panel

Comment 22 Joanne O'Flynn 2018-08-13 10:31:27 UTC
This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible.

If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-".


To add draft documentation text:

* Select the documentation type from the "Doc Type" drop down field.

* A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field.

Comment 24 errata-xmlrpc 2018-08-29 16:32:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2573