Bug 1555245
| Summary: | service-catalog crashed with segment fault when update serviceinstance to an invalid plan then delete project | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Zihan Tang <zitang> |
| Component: | Service Catalog | Assignee: | Jay Boyd <jaboyd> |
| Status: | CLOSED ERRATA | QA Contact: | Zihan Tang <zitang> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.9.0 | CC: | chezhang, jaboyd, jiazha, zhsun, zitang |
| Target Milestone: | --- | ||
| Target Release: | 3.10.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: Plan ID was being pulled from the Spec which is not right, it should always come from the InProgressProperties during update & delete.
Consequence: If plan was invalid, it may result in a seg fault.
Fix: Get the plan from the InProgressProperties
Result:
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-30 19:10:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Zihan Tang
2018-03-14 09:29:59 UTC
We draft this bug as two reasons: 1. service-catalog should not crash although this is a negative case 2. we understand that update plan of serviceinstance should base on web console allowed (such as dev/prod), but have similar bug got fix in previous https://bugzilla.redhat.com/show_bug.cgi?id=1507595 I set target release to 3.10 as two reasons, please correct me if you think 3.9.0 or 3.9.z is better. 1. Normal user cannot update a serviceinstance to a invalid plan from web console 2. Will not hit this issue if user not try to delete project although user update a serviceinstance to a invalid plan from backend. There has been a lot of change in the instance & binding reconcilation control loops upstream. I tried to reproduce this in master and I can not reproduce a crash. When I deleted the namespace the instance was removed. No crash. I believe this root issue has been fixed, could you please see if you can reproduce in 3.10? I'll try to reproduce when 3.10 image is ready. If couldn't produce , we can marked as fixed in 3.10. I use service catalog v0.1.13, I can still reproduce the bug. the controller-manager crashed with error panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15320f8] step: 1. provision apb in dev plan 2. edit serviceinstace plan to dev123 3. delete project I reproduced. The key is to use a Broker that implements an async delete. I'm reviewing an upstream fix. will be fixed upstream by https://github.com/kubernetes-incubator/service-catalog/pull/1941 I'm hoping to get that merged today so we can pick it up in openshift. This is in v0.1.19 of upstream service catalog and will be picked up with OpenShift builds done AFTER May 18 17:00 US Eastern. I believe this will be 3.10.0-0.48.0 or newer fixed by https://github.com/kubernetes-incubator/service-catalog/pull/1941 included in OpenShift https://github.com/openshift/service-catalog/pull/8 image is ready ,change it ot ON_QA Verified v3.10.0-0.50.0;Upstream:v0.1.19 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1816 |