Bug 1555334

Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/e939d18/golang-x-sync.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00728055-golang-x-sync/golang-x-sync-0-0.3.20180314gitfd80eb9.fc29.src.rpm

*** Bug 1556904 has been marked as a duplicate of this bug. ***

$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-x-sync-0-0.3.20180315gitfd80eb9.fc24.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-x-sync-devel-0-0.3.20180315gitfd80eb9.fc24.noarch.rpm
golang-x-sync.src: W: no-%build-section
golang-x-sync-devel.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
golang-x-sync-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/golang.org/x/sync/.goipath
golang-x-sync-devel.noarch: E: zero-length /usr/share/gocode/src/golang.org/x/sync/.goipath
2 packages and 0 specfiles checked; 1 errors, 3 warnings.

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=25729980

Nits:

> Provides: golang-github-golang-sync-devel = %{version}-%{release}

Given the go packages are still as build-time dependencies only and a package is never supposed to BR package name (rather virtual provides), this is not necessary. Just saying. No blocker for the review.

Thank you for the review.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-x-sync

golang-x-sync-0-0.3.20180316gitfd80eb9.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-41d91bc823

Happy to help. Can you build the package for f27 as well?

Package exists in F27 under the old name. Available through golang(golang.org/x/sync). Is there an issue with it?

https://src.fedoraproject.org/rpms/golang-github-golang-sync/blob/f27/f/golang-github-golang-sync.spec

golang-x-sync-0-0.3.20180316gitfd80eb9.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-41d91bc823

> Package exists in F27 under the old name. Available through golang(golang.org/x/sync). Is there an issue with it?

There is not. It is just easy to forget to update it in F27. In that case could you please update golang-github-golang-sync in f27 as well and override both f27 and f28 builds? I am about to package https://github.com/golang/dep/releases/tag/v0.4.1 into Fedora and it would be great to have it in f27+. Thanks

Ok the package is actually missing the Provides golang(golang.org/x/sync).

I'm hitting an issue when rebuilding for F27 though:

DEBUG util.py:439:  Last metadata expiration check: 0:00:00 ago on Sun 18 Mar 2018 04:56:40 PM UTC.
DEBUG util.py:439:  Dependencies resolved.
DEBUG util.py:439:  ================================================================================
DEBUG util.py:439:   Package                      Arch   Version                        Repository
DEBUG util.py:439:                                                                             Size
DEBUG util.py:439:  ================================================================================
DEBUG util.py:439:  Installing:
DEBUG util.py:439:   go-compilers-golang-compiler x86_64 1-27.fc27                      build 1.4 M
DEBUG util.py:439:   golang-golang-org-net-devel  x86_64 0-0.43.20180308git66aacef.fc27 build 623 k
DEBUG util.py:439:  Installing dependencies:
DEBUG util.py:439:   golang                       x86_64 1.9.4-1.fc27                   build 622 k
DEBUG util.py:439:   golang-bin                   x86_64 1.9.4-1.fc27                   build  48 M
DEBUG util.py:439:   golang-github-golang-sys-devel
DEBUG util.py:439:                                x86_64 0-0.18.20180305gitf6cff07.fc27 build  72 k
DEBUG util.py:439:   golang-golangorg-%{repo}-devel
DEBUG util.py:439:                                noarch 0-0.23.20180315git3bd178b.fc27 build 2.9 M
DEBUG util.py:439:   golang-golangorg-crypto-devel
DEBUG util.py:439:                                x86_64 0-0.20.20180306git9419663.fc27 build 799 k
DEBUG util.py:439:   golang-golangorg-tools-devel noarch 0-15.1.git9deed8c.fc26         build 1.0 M
DEBUG util.py:439:   golang-src                   noarch 1.9.4-1.fc27                   build 5.2 M
DEBUG util.py:439:  Transaction Summary
DEBUG util.py:439:  ================================================================================
DEBUG util.py:439:  Install  9 Packages
DEBUG util.py:439:  Total download size: 61 M
DEBUG util.py:439:  Installed size: 252 M
DEBUG util.py:439:  Downloading Packages:
DEBUG util.py:439:  Error: Error downloading packages:
DEBUG util.py:439:    Cannot download toplink/packages/golang-googlecode-text/0/0.23.20180315git3bd178b.fc27/noarch/golang-golangorg-%{repo}-devel-0-0.23.20180315git3bd178b.fc27.noarch.rpm: All mirrors were tried


It's looking for a package golang-golangorg-%{repo}-devel instead of golang-golangorg-text-devel. I don't know where the error is coming from because it works locally when I try to install that package but fails in mock. Any hint?

I think I've found this issue and sent you PR accordingly: https://src.fedoraproject.org/rpms/golang-googlecode-text/pull-requests

Let me know when you have rebuilt and override for F27 so I can do the same with this package.

$ koji wait-repo f28-build --build=golang-googlecode-text-0-0.24.20180315git3bd178b.fc28

$ koji wait-repo f27-build --build=golang-googlecode-text-0-0.24.20180315git3bd178b.fc27

 - Wait for you repo with:

koji wait-repo f27-build --build=golang-github-golang-sync-0-0.2.20171101gitfd80eb9.fc27


Would you like to be comaintainer on this package?

> Would you like to be comaintainer on this package?

Absolutely :) Thank you

golang-x-sync-0-0.3.20180316gitfd80eb9.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

golang-x-sync-0-0.3.20180316gitfd80eb9.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ed8d04d48

golang-x-sync-0-0.3.20180316gitfd80eb9.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ed8d04d48

golang-x-sync-0-0.3.20180316gitfd80eb9.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.