Bug 1555345
| Summary: | Review Request: golang-github-bitly-simplejson - Go package to interact with arbitrary JSON | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <eclipseo> |
| Component: | Package Review | Assignee: | Jared Smith <jsmith.fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsmith.fedora, package-review, tuxfed21 |
| Target Milestone: | --- | Flags: | jsmith.fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-05-19 21:23:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert-André Mauchin 🐧
2018-03-14 14:10:38 UTC
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/0a2d706/golang-github-bitly-simplejson.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/jid/fedora-rawhide-x86_64/00728059-golang-github-bitly-simplejson/golang-github-bitly-simplejson-0.5.0-3.fc29.src.rpm Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". 8
files have unknown license. Detailed output of licensecheck in
/home/djb/golang-github-bitly-simplejson/licensecheck.txt
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/bitly(golang-github-bitly-go-
simplejson-devel), /usr/share/gocode/src/github.com/bitly/go-
simplejson(golang-github-bitly-go-simplejson-devel),
/usr/share/gocode/src/github.com(golang-github-3rf-mongo-lint-devel,
golang-github-zyedidia-clipboard-devel, golang-github-hashicorp-hil-
devel, golang-github-ghodss-yaml-devel, golang-github-jmhodges-levigo-
devel, golang-github-gengo-grpc-gateway-devel, golang-github-gonum-
graph-devel, golang-github-digitalocean-godo-devel, golang-github-
codegangsta-cli-devel, golang-github-kdar-factorlog-devel, golang-
github-gorilla-securecookie-devel, golang-github-google-gofuzz-devel,
etcd-devel, golang-github-inconshreveable-muxado-devel, golang-github-
hashicorp-consul-migrate-devel, golang-github-karlseguin-expect-devel,
golang-github-Sirupsen-logrus-devel, golang-github-godbus-dbus-devel,
golang-github-hashicorp-raft-mdb-devel, golang-github-spacemonkeygo-
spacelog-devel, golang-github-sdboyer-constext-devel, golang-github-
akrennmair-gopcap-devel, golang-github-billziss-gh-cgofuse-devel,
golang-github-hashicorp-errwrap-devel, golang-github-dvsekhvalnov-
jose2go-devel, golang-github-kr-text-devel, golang-github-coreos-
gexpect-devel, golang-github-zyedidia-glob-devel, golang-github-
bugsnag-panicwrap-devel, golang-github-blang-semver-devel, golang-
github-pelletier-go-toml-devel, golang-github-d2g-dhcp4-devel, golang-
github-zyedidia-pty-devel, golang-github-hashicorp-net-rpc-msgpackrpc-
devel, golang-github-kimor79-gollectd-devel, golang-github-coreos-
bbolt-devel, golang-github-boltdb-bolt-devel, golang-github-
karlseguin-ccache-devel, golang-github-bradfitz-http2-devel, golang-
github-bmizerany-perks-devel, golang-github-aws-aws-sdk-go-devel,
golang-github-gorilla-websocket-devel, golang-github-gonum-lapack-
devel, golang-github-hashicorp-serf-devel, golang-googlecode-
goprotobuf-devel, golang-github-d2g-dhcp4client-devel, golang-github-
yuin-gopher-lua-devel, golang-github-eapache-queue-devel, golang-
github-garyburd-redigo-devel, golang-github-spf13-pflag-devel, glide-
devel, golang-github-denverdino-aliyungo-devel, golang-github-rfjakob-
eme-devel, golang-github-vividcortex-ewma-devel, golang-github-
dgnorton-goback-devel, golang-github-kr-pty-devel, golang-github-
hashicorp-memberlist-devel, golang-github-nsf-termbox-devel, golang-
github-mattn-go-runewidth-devel, golang-github-jinzhu-gorm-devel,
golang-github-jonboulle-clockwork-devel, golang-github-robertkrimen-
otto-devel, golang-github-russross-blackfriday-devel, golang-github-
hashicorp-raft-devel, golang-github-magiconair-properties-devel,
golang-github-zyedidia-tcell-devel, golang-github-cpuguy83-go-md2man-
devel, golang-github-cheggaaa-pb-devel, golang-github-ncw-acd-devel,
golang-github-cockroachdb-cmux-devel, golang-github-hashicorp-mdns-
devel, golang-github-lib-pq-devel, golang-github-nwidger-jsoncolor-
devel, golang-github-hashicorp-yamux-devel, golang-github-
spacemonkeygo-flagfile-devel, golang-github-circonus-labs-
circonusllhist-devel, golang-github-klauspost-crc32-devel, golang-
github-gonum-matrix-devel, golang-gopkg-yaml-devel-v2, golang-github-
kr-fs-devel, golang-github-grpc-ecosystem-grpc-gateway-devel, golang-
github-abbot-go-http-auth-devel, golang-github-unknwon-goconfig-devel,
golang-github-Masterminds-vcs-devel, golang-github-influxdb-rocksdb-
devel, golang-github-imdario-mergo-devel, golang-github-google-btree-
devel, golang-github-influxdb-gomdb-devel, golang-github-gogo-
protobuf-devel, golang-github-coreos-pkg-devel, golang-github-bgentry-
speakeasy-devel, golang-github-nightlyone-lockfile-devel, golang-
github-kylelemons-godebug-devel, golang-github-jtolds-gls-devel,
golang-github-xanzy-ssh-agent-devel, golang-github-kr-pretty-devel,
mongo-tools-devel, golang-github-julienschmidt-httprouter-devel,
golang-github-inconshreveable-mousetrap-devel, golang-github-zyedidia-
poller-devel, golang-github-gorilla-context-devel, golang, golang-
github-evanphx-json-patch-devel, golang-github-juju-ratelimit-devel,
golang-github-hashicorp-logutils-devel, golang-github-gonum-blas-
devel, golang-github-gorilla-mux-devel, golang-github-chzyer-logex-
devel, golang-github-gonum-floats-devel, golang-github-jessevdk-go-
flags-devel, golang-github-hashicorp-hcl-devel, golang-github-
BurntSushi-toml-devel, golang-github-AdRoll-goamz-devel, golang-
github-docker-spdystream-devel, golang-github-beorn7-perks-devel,
golang-github-hashicorp-scada-client-devel, golang-github-jlaffaye-
ftp-devel, golang-github-hashicorp-raft-boltdb-devel, golang-github-
docker-libtrust-devel, golang-github-flynn-json5-devel, golang-github-
howeyc-gopass-devel, golang-github-cenkalti-backoff-devel, golang-
github-jmank88-nuts-devel, golang-github-miekg-dns-devel, golang-
github-agl-ed25519-devel, golang-github-gorilla-handlers-devel,
golang-github-spf13-cast-devel, golang-github-armon-circbuf-devel,
golang-github-spf13-cobra-devel, golang-github-bmizerany-pat-devel,
golang-github-armon-go-radix-devel, golang-github-jacobsa-
oglematchers-devel, golang-github-bmizerany-assert-devel, golang-
github-zyedidia-terminal-devel, golang-github-armon-gomdb-devel,
golang-github-chzyer-test-devel, golang-github-pkg-errors-devel)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: golang-github-bitly-simplejson-devel-0.5.0-3.fc29.noarch.rpm
golang-github-bitly-simplejson-0.5.0-3.fc29.src.rpm
golang-github-bitly-simplejson-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/bitly/go-simplejson/.goipath
golang-github-bitly-simplejson-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/bitly/go-simplejson/.goipath
golang-github-bitly-simplejson.src: W: no-%build-section
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
golang-github-bitly-simplejson-devel.noarch: W: invalid-url URL: https://github.com/bitly/go-simplejson <urlopen error [Errno -2] Name or service not known>
golang-github-bitly-simplejson-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/bitly/go-simplejson/.goipath
golang-github-bitly-simplejson-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/bitly/go-simplejson/.goipath
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Requires
--------
golang-github-bitly-simplejson-devel (rpmlib, GLIBC filtered):
Provides
--------
golang-github-bitly-simplejson-devel:
golang(github.com/bitly/go-simplejson)
golang-github-bitly-go-simplejson-devel
golang-github-bitly-simplejson-devel
golang-ipath(github.com/bitly/go-simplejson)
Source checksums
----------------
https://github.com/bitly/go-simplejson/archive/v0.5.0.tar.gz#/go-simplejson-0.5.0.tar.gz :
CHECKSUM(SHA256) this package : 44196c95263e74277372319e5a6cb7f53b29ef7ddab8c7fed6ce6fc80144d465
CHECKSUM(SHA256) upstream package : 44196c95263e74277372319e5a6cb7f53b29ef7ddab8c7fed6ce6fc80144d465
It doesn't look like this was actually marked as approved by xtify21. I have also reviewed this package, and it is APPROVED. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bitly-simplejson golang-github-bitly-simplejson-0.5.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9671c15713 golang-github-bitly-simplejson-0.5.0-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9671c15713 golang-github-bitly-simplejson-0.5.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. golang-github-bitly-simplejson-0.5.0-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ac63e9a92e golang-github-bitly-simplejson-0.5.0-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ac63e9a92e golang-github-bitly-simplejson-0.5.0-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |