Bug 155544

Summary: requeued IO does not have BIO_RW_FAILFAST set.
Product: [Fedora] Fedora Reporter: Lars Marowsky-Bree <lmb>
Component: device-mapper-multipathAssignee: Alasdair Kergon <agk>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: agk, christophe.varoqui, dmo, lmb, tranlan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-04-21 20:05:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Move setting BIO_RW_FAILFAST to map_io() none

Description Lars Marowsky-Bree 2005-04-21 10:52:34 UTC
dm_bio_restore(), called just before requeuing, restores and overwrites our bio
flags. Attached patchlet fixes this.

Comment 1 Lars Marowsky-Bree 2005-04-21 10:52:35 UTC
Created attachment 113463 [details]
Move setting BIO_RW_FAILFAST to map_io()

Comment 2 Alasdair Kergon 2005-04-21 19:55:04 UTC
where does the overwriting happen?
bio_record.h doesn't touch bi_rw

Comment 3 Lars Marowsky-Bree 2005-04-21 20:05:29 UTC
Brown paper bag. You're right. I got confused by the setting of bi_flags, but
bi_rw_failfast is in a different field as you correctly point out; maybe I was
looking for bugs a little bit _too_ hard.

Closing bug, patch not needed ;)