Bug 1555683

Summary: cross-gcc: FTBFS in F28
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: cross-gccAssignee: David Howells <dhowells>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 28CC: alexey.brodkin, dan, dhowells, lkundrak, opensource, tcallawa
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cross-gcc-8.1.1-3.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-31 18:01:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1555378    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2018-03-14 19:29:24 UTC
Your package cross-gcc failed to build from source in current F28.

https://koji.fedoraproject.org/koji/taskinfo?taskID=24776021

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild

Comment 1 Till Maas 2018-05-29 10:26:00 UTC
Created attachment 1445322 [details]
build.log

new failed build:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1086915

The full log is too bug to be added here (>100MB)

Comment 2 Fedora Release Engineering 2018-05-29 10:49:56 UTC
Created attachment 1445328 [details]
root.log

Comment 3 Fedora Release Engineering 2018-05-29 10:50:37 UTC
Created attachment 1445329 [details]
state.log

Comment 4 Zbigniew Jędrzejewski-Szmek 2018-07-09 04:06:32 UTC
Dear Maintainer,

your package has not been built successfully in F28. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. Following the latest policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://fedoraproject.org/wiki/Fails_to_build_from_source#Package_Removal_for_Long-standing_FTBFS_bugs

Comment 5 Alexey Brodkin 2018-07-10 21:24:50 UTC
The problem is missing ";;" in https://src.fedoraproject.org/cgit/rpms/cross-gcc.git/commit/?id=00a8cee6f61dd41916bb83a2df439a15e83468ab

So the fix is:
------------------------>8------------------------
diff --git a/cross-gcc.spec b/cross-gcc.spec
index 6d72123dec54..c2142ed53ffd 100644
--- a/cross-gcc.spec
+++ b/cross-gcc.spec
@@ -777,6 +777,7 @@ function install_lang () {
                ;;
            arm*)
                echo '/usr/arm-linux-gnueabi/lib/libgcc_s.so*'
+               ;;
            *)
                echo '/usr/lib/gcc/'$target_cpu'-*/'
                echo '%{_libexecdir}/gcc/'$target_cpu'*/*/cc1'
------------------------>8------------------------

Still this is no longer relevant as this part got removed again by https://src.fedoraproject.org/cgit/rpms/cross-gcc.git/commit/?id=70abf9e786bb9f9ad1976414e9081d9310dac39f

So this one could be safely closed.

Comment 6 David Howells 2018-07-12 08:30:15 UTC
Note that just adding a ";;" isn't sufficient, since it used to fall through I think.  I moved the libgcc_s addition into its own case statement.

Comment 7 Fedora Update System 2018-07-13 08:56:30 UTC
cross-gcc-8.1.1-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9a0d2245d5

Comment 8 Fedora Update System 2018-07-16 20:28:55 UTC
cross-gcc-8.1.1-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9a0d2245d5

Comment 9 Fedora Update System 2018-07-31 18:01:19 UTC
cross-gcc-8.1.1-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.