Bug 155616

Summary: system-config-samba doesn't gracefully handle syntax errors in smb.conf
Product: [Fedora] Fedora Reporter: Ian Richardson <ieuuk1987>
Component: system-config-sambaAssignee: Nils Philippsen <nphilipp>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: rawhideKeywords: FutureFeature
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-14 15:22:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
my old smb.conf
none
The fixed version of smb.conf none

Description Ian Richardson 2005-04-21 20:56:49 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)

Description of problem:
When you go to:
system settings > server settings > click on samba

It asks you for the root password and then just hangs afterwards.



Version-Release number of selected component (if applicable):
system-config-samba-1.2.21-1 and python-2.3.4-11

How reproducible:
Always

Steps to Reproduce:
1.system settings
2.server settings
3.click on samba
4.enter root password
  

Actual Results:  nothing comes up

Expected Results:  samba configuration tool to load up.

Additional info:

when system-config-samba is run from a terminal; it errors with:
" File "/usr/share/system-config-samba/sambaToken.py", line 36, in __init__
raise AttributeError, value
AttributeError: ('192.168.0.3', '') "

Problem is solved by removing my smb.conf and then making another.

Comment 1 Ian Richardson 2005-04-21 21:02:11 UTC
Created attachment 113489 [details]
my old smb.conf

This is the config file that the problem happens under

Comment 2 Ian Richardson 2005-04-21 21:03:34 UTC
Created attachment 113490 [details]
The fixed version of smb.conf

Once i had changed it to this smb.conf the problem was resolved

Comment 3 Nils Philippsen 2005-06-14 15:18:32 UTC
Your original smb.conf contains IP addresses on their own lines, these must be
on one line with the "host allow" parameter. I plan to change s-c-samba so that
it gives a suitable warning in that case.

Comment 4 Nils Philippsen 2008-08-14 15:22:34 UTC
Current system-config-samba-1.2.63-1.fc9.noarch gives such a warning and doesn't hang.