Bug 1557731
| Summary: | ERROR ASCII-8BIT to UTF-8","klass":"Encoding::UndefinedConversionError"}} | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Kevin Morey <kmorey> | ||||
| Component: | API | Assignee: | Gregg Tanzillo <gtanzill> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nandini Chandra <nachandr> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.9.0 | CC: | cpelland, hkataria, kmorey, lavenel, ldomb, lgalis, mhradil, mkanoor, mpovolny, obarenbo, smallamp, sshveta, tfitzger, yrudman | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.10.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1566572 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-02-11 14:01:39 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1566572 | ||||||
| Attachments: |
|
||||||
|
Description
Kevin Morey
2018-03-18 06:18:16 UTC
Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set the severity to Low. Hey Kevin , I am not able to recreate this issue on 5.9.1.0.20180314203929_67fd99d. can you please check appliance https://10.8.196.183. I have created few ansible services with different playbooks . Can you attach the playbook that you used. Thanks, Shveta Playbooks used : https://github.com/patchkez/ansible_playbooks/blob/master/become_root_and_touch.yml and https://github.com/patchkez/ansible_playbooks/blob/master/dump_all_variables.yml I can see the error in Kevin's system. May be it is something to with Regex pattern validation in the dialog . Dan , I have an appliance where I have the ansible playbook used in this BZ. Someone from dev will have to take a look at the logs to understand more . Created attachment 1410270 [details]
Screenshot of Ansible Output
Lucy - Please review. We may need to ask the Ansible team about comoment #14. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0559e91d4d9e6ab8f994d787a18c146e929d65a2 commit 0559e91d4d9e6ab8f994d787a18c146e929d65a2 Author: Tim Wade <hello> AuthorDate: Wed Apr 4 15:20:57 2018 -0400 Commit: Tim Wade <hello> CommitDate: Wed Apr 4 15:20:57 2018 -0400 Force UTF-8 encoding on task results Since task results are stored as binary blobs, they can be set as strings in whatever encoding you like. This can create problems for the API, which blindly tries to convert all attributes to JSON - any value containing ASCII with ansi escape codes will fail with a conversion error. It seems reasonable to expect that all string values should be encoded as UTF-8 - the alternative is for the API to have to force the encoding on every single string that comes its way. This change forces incoming values to be converted to UTF-8 prior to being stored. It will also convert outgoing values in the case that they have already been persisted prior to this change - though this extra check I'm sure could eventually be removed. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557731 app/models/miq_task.rb | 4 +- spec/models/miq_task_spec.rb | 23 + 2 files changed, 26 insertions(+), 1 deletion(-) Verified in 5.10.0.23 |