Bug 1558043

Summary: Guest VM with USB support enabled is unresponsive after migration
Product: Red Hat Enterprise Linux 7 Reporter: Radek Duda <rduda>
Component: spice-gtkAssignee: Victor Toso <victortoso>
Status: CLOSED ERRATA QA Contact: SPICE QE bug list <spice-qe-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 7.5CC: cfergeau, chayang, coli, jinzhao, juzhang, michen, mtessun, ngu, qzhang, spice-qe-bugs, tpelka, victortoso, virt-maint
Target Milestone: rcKeywords: Regression, TestBlocker, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spice-gtk-0.35-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1559041 1590412 (view as bug list) Environment:
Last Closed: 2018-10-30 10:51:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1559041, 1590412    
Attachments:
Description Flags
spice debug log during migration
none
full backtrace after migratin and closing of remote-viewer none

Description Radek Duda 2018-03-19 13:46:58 UTC
Created attachment 1409868 [details]
spice debug log during migration

Description of problem:
Guest VM is unresponsive after migration

Version-Release number of selected component (if applicable):
client (rhel7.5)
spice-gtk3-0.34-3.el7.x86_64
virt-viewer-5.0-10.el7.x86_64

host (rhel7.5):
qemu-kvm-rhev-2.9.0-16.el7_4.15.x86_64
spice-server-0.14.0-2.el7.x86_64

guest (rhel7.5 (rhel6.9 also reproducible as well))
kernel-3.10.0-861.el7.x86_64

using rhv 4.2.2.4-0.1.el7

How reproducible:
always

Steps to Reproduce:
1.run rhel VM in rhv4.2
2.connect to it with remote-viewer
3.migrate
4. after migration interact with guest using mouse/keyboard

Actual results:
* Vm guest becomes unresponsive through remote-viewer
* remote-viewer is killed by SIGSEGV when user attempts to close it (backtrace attached)


Expected results:
After migration VM guest is responding to user's input through remote-viewer

Additional info:

Comment 2 Radek Duda 2018-03-19 13:48:56 UTC
Created attachment 1409869 [details]
full backtrace after migratin and closing of remote-viewer

Comment 4 Radek Duda 2018-03-20 12:13:05 UTC
Freeze is dependent on USB support. If disabled, there is no freeze. Reproducible also on Windows7 guest.

Comment 5 Ademar Reis 2018-03-20 13:55:28 UTC
Based on the description and investigation so far, I have the impression this is a qemu-kvm-rhev regression. Gerd, please take a look.

More tests from our QE to isolate the problem and the component are also welcome.

Comment 7 Christophe Fergeau 2018-03-20 14:49:09 UTC
Moving back to spice-gtk, this is the client freezing, not the whole VM. After restarting the client, the VM is usable.

Comment 8 Christophe Fergeau 2018-03-20 14:52:58 UTC
I've bisected this to
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=291f3e44
"291f3e4 channel-usbredir: Fix crash on channel-up"
I started a scratch build with this commit reverted:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15593734
Radek, can you give it a try once it completes?

Comment 10 Victor Toso 2018-04-06 08:04:58 UTC
Hi, took sometime thinking on it but seems the revert is indeed the best.

The patch in question fixes Bug 1399838 but it is far more easy to revert and fix that bug in a different way instead of trying to keep migration working with that patch in.

Revert sent upstream [0] and simple proposal to fix crash from Bug 1399838 sent as well [1]

[0] https://lists.freedesktop.org/archives/spice-devel/2018-April/042965.html
[1] https://lists.freedesktop.org/archives/spice-devel/2018-April/042966.html

Comment 11 Victor Toso 2018-06-12 13:26:01 UTC
For 7.6 it should be solved by rebase as it includes the proposed patches from Comment #10

Comment 17 errata-xmlrpc 2018-10-30 10:51:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3175