Bug 1558128

Summary:	argon2: Incomplete Fedora build flags injection
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	argon2	Assignee:	Remi Collet <fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	fedora
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	argon2-20161029-5.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-01 00:42:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-03-19 17:03:41 UTC

/usr/bin/argon2 in argon2-20161029-4.fc28.x86_64 and /usr/lib64/libargon2.so.0 in libargon2-20161029-4.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config:

cc -std=c89 -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -g -Iinclude -Isrc  src/argon2.c src/core.c src/blake2/blake2b.c src/thread.c src/encoding.c src/opt.c src/run.c -o argon2
…
cc -std=c89 -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -g -Iinclude -Isrc -shared -fPIC -fvisibility=hidden -DA2_VISCTL=1  -Wl,-soname,libargon2.so.0 src/argon2.c src/core.c src/blake2/blake2b.c src/thread.c src/encoding.c src/opt.c -o libargon2.so

CFLAGS are there, but LDFLAGS are missing.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Remi Collet 2018-03-20 13:18:01 UTC

Fixed by https://src.fedoraproject.org/rpms/argon2/c/a65cc9516cbcd51498b102bdd32f6d11168f6212?branch=f28

Comment 2 Fedora Update System 2018-03-20 13:24:06 UTC

argon2-20161029-5.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-afb832ae0e

Comment 3 Fedora Update System 2018-03-20 14:55:52 UTC

argon2-20161029-5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-afb832ae0e

Comment 4 Fedora Update System 2018-04-01 00:42:00 UTC

argon2-20161029-5.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.