Bug 1558380

Summary:	Modify glfsheal binary to accept socket file path as an optional argument.
Product:	[Community] GlusterFS	Reporter:	Vishal Pandey <vpandey>
Component:	selfheal	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-v4.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-20 18:02:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vishal Pandey 2018-03-20 06:46:57 UTC

Description of problem:

Currently glfsheal uses DATADIR + /run/socketfile as the socket file path but in cases like the following the gluster management daemon is likely to run into issues-

1- In Gluster 4.0, both Glusterd1 and Glusterd2 can run together if ports and socket file is configured as different. In that case glfs heal will only work with one Glusterd.

2-  Run multiple glusterd2 in same machine to form the Cluster for testing. Both can't use the same socket file.

Keeping in mind the above use cases it is better to make glfsheal more flexible to accomodate option for specifying socketfile path.
 
Version-Release number of selected component (if applicable):
4.0

Comment 1 Worker Ant 2018-03-20 09:41:01 UTC

REVIEW: https://review.gluster.org/19745 (glfs heal binary change to accomodate socket file arguments) posted (#1) for review on master by

Comment 2 Worker Ant 2018-03-26 06:24:36 UTC

REVIEW: https://review.gluster.org/19745 (glfs heal binary change to accomodate socket file arguments) posted (#2) for review on master by

Comment 3 Worker Ant 2018-03-27 02:24:38 UTC

COMMIT: https://review.gluster.org/19745 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- glfs heal binary change to accomodate socket file arguments

Change-Id: I755d6552decd015aec7859ad2cf99c76c8bee9dc
fixes: bz#1558380
BUG: 1558380
Signed-off-by: Vishal Pandey <vpandey>

Comment 4 Shyamsundar 2018-06-20 18:02:26 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/