Bug 1558559

Summary: On successfully deployment it still shows deploy button
Product: [oVirt] cockpit-ovirt Reporter: Simone Tiraboschi <stirabos>
Component: Hosted EngineAssignee: Phillip Bailey <phbailey>
Status: CLOSED CURRENTRELEASE QA Contact: Yihui Zhao <yzhao>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 0.11.17CC: bugs, cshao, huzhao, qiyuan, rbarry, sbonazzo, yaniwang, ycui, yzhao
Target Milestone: ovirt-4.2.2Flags: rule-engine: ovirt-4.2+
yzhao: testing_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.18-0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 11:17:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
close_1
none
close_2
none
failed_deploy1
none
failed_deploy2 none

Description Simone Tiraboschi 2018-03-20 13:41:26 UTC
Description of problem:
On successfully deployment we still show deploy button, see close_1.png,
pressing it the wizard goes back to the initial page with "Hosted engine setup was aborted" see close_2.png

Version-Release number of selected component (if applicable):
0.11.17

How reproducible:
100%

Steps to Reproduce:
1. deploy hosted-engine from cockpit
2.
3.

Actual results:
On successfully deployment it still shows deploy button

Expected results:
On successfully deployment it still close button and pressing it moves to the status page

Additional info:

Comment 1 Simone Tiraboschi 2018-03-20 13:41:53 UTC
Created attachment 1410500 [details]
close_1

Comment 2 Simone Tiraboschi 2018-03-20 13:42:16 UTC
Created attachment 1410501 [details]
close_2

Comment 3 Yihui Zhao 2018-03-21 02:08:37 UTC
Created attachment 1410918 [details]
failed_deploy1

Comment 4 Yihui Zhao 2018-03-21 02:17:40 UTC
Created attachment 1410919 [details]
failed_deploy2

Comment 5 Yihui Zhao 2018-03-21 02:18:38 UTC
See the attachment 1410918 [details].

When deployed failed on create the storage domain, the cockpit buttons are confused. See the attachment 1410918 [details].

1. click "Redeploy" button  : its function  is re-deploy the process

2. click "Finish Deployment" button : its function is  re-deploy the process

3. click "Deploy"  button, the "Deploy" button will change to the "close" button,
  see the attachment 1410919 [details]

Comment 6 Yihui Zhao 2018-03-21 05:36:08 UTC
(In reply to Yihui Zhao from comment #5)
> See the attachment 1410918 [details].
> 
> When deployed failed on create the storage domain, the cockpit buttons are
> confused. See the attachment 1410918 [details].
> 
> 1. click "Redeploy" button  : its function  is re-deploy the process
> 
> 2. click "Finish Deployment" button : its function is  re-deploy the process
> 
> 3. click "Deploy"  button, the "Deploy" button will change to the "close"
> button,
>   see the attachment 1410919 [details]


File a bug to track:  https://bugzilla.redhat.com/show_bug.cgi?id=1558826

Comment 7 Phillip Bailey 2018-03-21 13:14:14 UTC
The existing patches [1][2] fix the buttons displayed on successful and failed execution of the final step. The behavior of the close button still needs to be corrected. Once that patch is completed and merged, I will move this to MODIFIED.

[1] https://gerrit.ovirt.org/#/c/89289/
[2] https://gerrit.ovirt.org/#/c/89290/

Comment 8 Yihui Zhao 2018-03-26 07:03:41 UTC
Tested with these versions:

rhvh-4.2.2.0-0.20180322.0+1
cockpit-ovirt-dashboard-0.11.19-1.el7ev.noarch
ovirt-hosted-engine-setup-2.2.14-1.el7ev.noarch
ovirt-hosted-engine-ha-2.2.7-1.el7ev.noarch
rhvm-appliance-4.2-20180322.0.el7.noarch


from the cockpit, on successfully deployment, it didn't show the deploy button.Just the "close" button".


So,change the bug's status to verified.

Comment 9 Sandro Bonazzola 2018-03-29 11:17:07 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.