Bug 1558616

this only looks partially fixed.

1. the "-q" and "--quiet" flags work now:
[root@dell-per715-01 ~]# rngd --quiet
[root@dell-per715-01 ~]# rngd -q
[root@dell-per715-01 ~]# rngd
Failed to init entropy source 0: Hardware RNG Device

Failed to init entropy source 1: TPM RNG Device

Failed to init entropy source 2: Intel RDRAND Instruction RNG

can't open any entropy source
Maybe RNG device modules are not loaded

In rng-tools-5-13.el7.x86_64, it was failing:
[root@dell-per715-01 ~]# rngd -q
Failed to init entropy source 0: Hardware RNG Device

Failed to init entropy source 1: TPM RNG Device

Failed to init entropy source 2: Intel RDRAND Instruction RNG


2. the "-d" is still described differently in "--help" and manual:
[root@dell-per715-01 ~]# rngd --help
(...)
  -d, --no-drng=1|0          Do not use drng as a source of random number input
[root@dell-per715-01 ~]# man rngd
(...)
       -d, --debug
              Enable debug messages
(...)
(It requires an argument, so the "--help" version might be correct.)

3. additionally, the "--debug" flag is not documented in "--help", and seems not to work:
[root@dell-per715-01 ~]# rngd --debug
rngd: unrecognized option '--debug'
Try `rngd --help' or `rngd --usage' for more information.


Putting back to ASSIGNED.

Neil, are we waiting for something? It looks you fixed this a week ago, but it is not yet ON_QA

The errata tool was broken last week, I just hadn't gotten to updating the errata

actually, the build is missing a product listing now in the errata tool, and I have no idea what that means.

Now the documentation is OK and the switches work:

# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.6 Beta (Maipo)

# rpm -q rng-tools
rng-tools-6.3.1-1.el7.x86_64

# rngd --help
...
  -d, --debug                Enable debug output
...
  -q, --quiet                Suppress error messages
...

# man rngd
..
-d, --debug
              Enable debug messages
...
-q, --quiet
              Suppress error messages
...

# rngd
Initalizing available sources
Failed to init entropy source 0: Hardware RNG Device
Failed to init entropy source 1: TPM RNG Device
Enabling RDRAND rng support
Enabling JITTER rng support

# rngd --debug
Initalizing available sources
read error
hwrng: no available rng
Failed to init entropy source 0: Hardware RNG Device
Unable to open file: /dev/tpm0
Failed to init entropy source 1: TPM RNG Device
Enabling RDRAND rng support
Enabling JITTER rng support
(same for 'rngd -d')

However, the quiet mode is now more verbose than it was in Comment #4:
# rngd --quiet
Initalizing available sources
Enabling RDRAND rng support
Enabling JITTER rng support
(same for 'rngd -q')

Neil, is this on purpose? This is consistent with the description, saying that '--quiet' just disables error messages, but do we really want to have diagnostic lines like 'Initializing available sources' printed in the quiet mode?

no, its not correct, but that seems to be a different bug.  It appears a message slipped in that circumvents the quiet filter for the rngd enhancement update (which introduced the jitter source).

If you could open a separate bug on that, I'll get it squared up

Okay, opened Bug 1609888 - verbose 'rngd --quiet', closing this one.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3022