Bug 155891

Summary: kernel dm-mpath: Decode any SCSI sense data if no hw_handler
Product: [Fedora] Fedora Reporter: Lars Marowsky-Bree <lmb>
Component: device-mapper-multipathAssignee: Alasdair Kergon <agk>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: agk, christophe.varoqui, dmo, dwysocha, lmb, mbroz, tranlan
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-09 21:54:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch none

Description Lars Marowsky-Bree 2005-04-25 14:12:13 UTC 
If no hw-handler is loaded, the dm_scsi_error_handler is never called. Wouldn't
it be sane to always call as the default error decoder it if no explicit
hw-handler is in place? It would only change the default behaviour in case SCSI
sense data was available, so it'd be pretty safe.

Given that probably >90% of all multipath deployments are going to be based on
SCSI, I think that would make a lot of sense.
Comment 1 Lars Marowsky-Bree 2005-04-26 10:54:29 UTC 
Created attachment 113662 [details]
Proposed patch

How about this one.
Comment 2 Alasdair Kergon 2005-05-04 13:58:59 UTC 
Seems a reasonable thing to do.
Comment 3 Alasdair Kergon 2005-05-04 14:01:19 UTC 
If it ever causes problems in the future, we can simply move it into a SCSI
hw_handler and expect userspace to choose it if there isn't a more-specific one
to use.
Comment 4 Alasdair Kergon 2005-05-04 14:07:11 UTC 
Adding to next -udm.
Comment 6 Alasdair Kergon 2011-02-09 21:54:29 UTC 
Old bz, superceded by hardware handler restructuring