Bug 1559019

Summary: CloudForms appliance is ignoring azure proxy settings in advanced tab.
Product: Red Hat CloudForms Management Engine Reporter: Justin Burdine <jburdine>
Component: ProvidersAssignee: Daniel Berger <dberger>
Status: CLOSED CURRENTRELEASE QA Contact: Brandon Squizzato <bsquizza>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: bsquizza, cpelland, dluong, gblomqui, jburdine, jfrey, jhardy, jocarter, mslemr, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1563268 (view as bug list) Environment:
Last Closed: 2019-02-11 14:07:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Azure Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1563268    
Attachments:
Description Flags
Error we are currently getting
none
Customer's advance tab settings none

Comment 5 Justin Burdine 2018-03-22 18:44:12 UTC
my apologies, the version we tested this on is 5.9.0.22 not 5.9.22 as stated in the description above.  I have tested that proxy settings for Azure do indeed work in 5.8.0.17.  I also found that on 5.9.0.22, Amazon is using the proxy but Azure is not.

hope this helps

Comment 7 Daniel Berger 2018-03-26 15:41:58 UTC
I cannot duplicate this locally on master. I created a local TLSv1 authenticating proxy using WEBrick on port 8080, fired up a local instance of cloudforms and adjusted the settings to point at it. I can see the traffic going through the proxy without issue.

I'll try on 5.9.022 next. In the meantime, can you provide more information about the proxy itself. Is it authenticating? What port is it using? What are the SSL settings on it, if any?

Comment 8 Daniel Berger 2018-03-26 16:57:41 UTC
I also tried 5.9.0.22, but was not able to replicate the issue. The proxy worked as expected.

Comment 9 Justin Burdine 2018-03-26 17:36:27 UTC
Hi Daniel, 

For my testing purposes (trying to replicate what the client is seeing) I'm using Squid, without any encryption.  When I'm on 5.9.0.22 I can see Amazon EC2 provider going through the proxy (using default proxy entry), however when I set the azure specific proxy entry, I don't see any traffic for Azure. 

I'll reach out to the customer and ask for specifics on their proxy.

Comment 12 CFME Bot 2018-03-28 20:39:35 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/b6d05345bd2820316215fdee8a8777f109495903
commit b6d05345bd2820316215fdee8a8777f109495903
Author:     Martin Slemr <mslemr>
AuthorDate: Wed Mar 28 06:18:57 2018 -0400
Commit:     Martin Slemr <mslemr>
CommitDate: Wed Mar 28 06:18:57 2018 -0400

    Makes http_proxy_uri class method

    Instance method uses new class method, which is needed by provider validation.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552114
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559019

 app/models/manageiq/providers/base_manager.rb | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comment 13 Martin Slemr 2018-03-29 07:49:43 UTC
Back to ON_DEV, there will be 2nd PR

Comment 14 Justin Burdine 2018-03-29 19:43:23 UTC
customer's specifics on their proxy server:

Software: BlueCoat appliances

Port: 8080 is what’s configured in the desktop environment, however we also tried just using 443.  We used 443 after finding the proxyserver worked when we set it in the UI for redhat updates.
 
I’ve attached two screen shots. 
 
Shows the error we are getting now the other shows the proxy configuration in the advanced tab

Comment 15 Justin Burdine 2018-03-29 19:45:02 UTC
Created attachment 1414885 [details]
Error we are currently getting

Comment 16 Justin Burdine 2018-03-29 19:48:13 UTC
Created attachment 1414886 [details]
Customer's advance tab settings

Comment 17 CFME Bot 2018-04-02 15:02:11 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/a7c478ed01008fcc59f5082ce3342a5d97bfde6f
commit a7c478ed01008fcc59f5082ce3342a5d97bfde6f
Author:     Martin Slemr <mslemr>
AuthorDate: Wed Mar 28 06:23:09 2018 -0400
Commit:     Martin Slemr <mslemr>
CommitDate: Wed Mar 28 06:23:09 2018 -0400

    Validation of new provider with proxy

    Validation of new Amazon,Azure,Google provider take care of http_proxy settings.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552114
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559019

 app/controllers/mixins/ems_common_angular.rb | 6 +-
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 19 Brandon Squizzato 2018-07-18 19:41:56 UTC
Verified on 5.10.0.4

Set up mitmproxy, ensured CFME->azure traffic is being routed through the proxy for these configurations:
1) azure proxy defined, no default proxy defined
2) azure proxy defined, default proxy defined w/ a bogus IP
3) no azure proxy defined, only default proxy defined

Works for all 3 cases.