Bug 1559126

Summary: Incorrect error message in /features/changelog/lib/src/gf-history-changelog.c
Product: [Community] GlusterFS Reporter: nh2 <nh2-redhatbugzilla>
Component: changelogAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, khiremat, kschinck, nh2-redhatbugzilla
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: glusterfs-v4.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1099294 Environment:
Last Closed: 2018-06-20 18:02:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description nh2 2018-03-21 18:18:14 UTC 
+++ This bug was initially created as a clone of Bug #1099294 +++

Description of problem:
In gf_history_changelog(), the same error message is logged if the check of the start time or end time fails "wrong result for start: %lu idx: %lu".

The second check should have a relavant error message "wrong result for end: %lu idx: %lu"

Version-Release number of selected component (if applicable):
3.5

How reproducible:
https://github.com/gluster/glusterfs/blame/master/xlators/features/changelog/lib/src/gf-history-changelog.c#L849

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-06-19 11:06:16 EDT ---

REVIEW: http://review.gluster.org/8121 (Provide correct error message for changelog end time check bug 1099294) posted (#1) for review on master by Keith Schincke (kschinck)

--- Additional comment from Mike McCune on 2016-03-28 18:53:35 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

--- Additional comment from Niels de Vos on 2016-06-17 12:24:39 EDT ---

This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.

--- Additional comment from Worker Ant on 2017-12-31 20:53:50 EST ---

REVIEW: https://review.gluster.org/19115 (Provide correct error message for changelog end time check bug 1099294) posted (#1) for review on master by Niklas Hambüchen
Comment 1 Worker Ant 2018-03-21 18:20:22 UTC 
REVIEW: https://review.gluster.org/19760 (Provide correct error message for changelog end time check bug 1559126) posted (#1) for review on master by Niklas Hambüchen
Comment 2 Worker Ant 2018-03-24 05:11:35 UTC 
COMMIT: https://review.gluster.org/19760 committed in master by "Amar Tumballi" <amarts> with a commit message- libgfchangelog: Correct the log message

Provide correct error message for changelog end time check
Updated error message to print "wrong result for end".

Original patch by Keith Schincke <kschinck>
from https://review.gluster.org/#/c/8121/

Change-Id: Ia3458cbac7784bfc71c05da67391a3f8259f18f0
BUG: 1559126
Signed-off-by: Niklas Hambüchen <mail>
Comment 3 Shyamsundar 2018-06-20 18:02:52 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/