Bug 1559141

Summary: '%transfiletriggerin' lua script for 'systemd-udev' is breaking package layering on Atomic Host
Product: [Fedora] Fedora Reporter: Micah Abbott <miabbott>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, dustymabe, jlebon, kevin, lnykryn, mboddu, msekleta, sgallagh, ssahani, s, systemd-maint, walters, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: systemd-238-7.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 19:22:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1469205    

Description Micah Abbott 2018-03-21 19:04:56 UTC
Using Fedora Rawhide Atomic Host, 'systemd-238-5' introduced a change that broke the package layering capability of 'rpm-ostree'.  See below:

# rpm-ostree status
State: idle; auto updates disabled
Deployments:
● ostree://custom:fedora/rawhide/x86_64/atomic-host
                   Version: Rawhide.20180321.n.0 (2018-03-21 10:19:44)
                    Commit: 1e0fc5658e23406947a1484106b3cebd45cc590ff689d0e4a41fa1137efcfefd

# rpm -q ostree rpm-ostree systemd systemd-udev
ostree-2018.2-1.fc28.x86_64
rpm-ostree-2018.3-2.fc29.x86_64
systemd-238-5.fc29.x86_64
systemd-udev-238-5.fc29.x86_64

# rpm-ostree install wget
Checking out tree 1e0fc56... done
Enabled rpm-md repositories: rawhide-modular rawhide

Updating metadata for 'rawhide-modular': [=============] 100%
rpm-md repo 'rawhide-modular'; generated: 2018-03-20 09:12:55

Updating metadata for 'rawhide': [=============] 100%
rpm-md repo 'rawhide'; generated: 2018-03-21 09:20:02

Importing metadata [=============] 100%
Resolving dependencies... done
Will download: 1 package (746.7 kB)

  Downloading from rawhide: [=============] 100%

Importing (1/1) [=============] 100%
Applying 1 overlay

Building filesystem (1/1) [=============] 100%
Running pre scripts... 0 done
Running post scripts... error: Executing %transfiletriggerin for systemd-udev: Package 'systemd-udev' has (currently) unsupported <lua> script in '%transfiletriggerin'


I believe the commit that caused this change is here:

https://src.fedoraproject.org/cgit/rpms/systemd.git/commit/?id=b5fa4adf3fe513262aa266fbe9a624ee5bc887e8


walters pointed me to this upstream discussion about the change to using 'lua' scripts, which is relevant here:

https://github.com/systemd/systemd/pull/8090#issuecomment-370635324

Comment 1 Colin Walters 2018-03-22 13:07:20 UTC
https://github.com/systemd/systemd/pull/8550

Comment 2 Adam Williamson 2018-03-27 20:45:00 UTC
Since pulling systemd-238-5 into Beta 1.1 (to fix accepted FE https://bugzilla.redhat.com/show_bug.cgi?id=1559629) broke this where it was working all the way up till then, proposing this as an FE. Colin is doing a systemd-238-6 which should fix this, I think it'd make sense to pull that in if we respin.

Comment 3 Fedora Update System 2018-03-27 21:43:12 UTC
systemd-238-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8082209c08

Comment 4 Dusty Mabe 2018-03-27 21:51:44 UTC
+1 FE. I'm biased, though

Comment 5 Stephen Gallagher 2018-03-27 22:05:51 UTC
+1 FE

Comment 6 Kevin Fenzi 2018-03-27 22:07:06 UTC
+1 FE, but I would want a lot of testing before we pull it in... this is something that is on every image. :)

Comment 7 Patrick Uiterwijk 2018-03-27 22:09:37 UTC
+1 FE with the same note as Kevin.

Comment 8 Fedora Update System 2018-03-27 23:23:19 UTC
systemd-238-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8082209c08

Comment 9 Dusty Mabe 2018-03-27 23:25:26 UTC
This is fixed in systemd-238-6.fc28.x86_64:

```
[root@localhost ~]# rpm-ostree status                      
State: idle; auto updates disabled                         
Deployments:                                               
● ostree://fedora-atomic:fedora/28/x86_64/testing/workstation                                                         
                   Version: 28_Update.20180327.2202 (2018-03-27 23:13:41)                                             
                    Commit: e1b71b732575309396d6e2ee3b8800d67c3810b025ba7e9b4527968b4df912eb                          
                                                                                                                      
  ostree://fedora-atomic:fedora/28/x86_64/testing/workstation                                                         
                   Version: 28_Update.20180326.1845 (2018-03-26 19:28:17)                                             
                    Commit: 25f473831afd254e756080a4bd3e527726e7624b9bd0979f0b91c33732120522                          
[root@localhost ~]# rpm -q systemd                         
systemd-238-6.fc28.x86_64                                                                                             
[root@localhost ~]#                                                                                                   
[root@localhost ~]#                                                                                                   
[root@localhost ~]# rpm-ostree install htop                                                                           
Checking out tree e1b71b7... done                          
Enabled rpm-md repositories: updates fedora updates-testing
rpm-md repo 'updates' (cached); generated: 2018-02-20 19:18:14                                                        
rpm-md repo 'fedora' (cached); generated: 2018-03-27 10:55:53                                                         
rpm-md repo 'updates-testing' (cached); generated: 2018-03-26 20:45:06                                                
                                                           
Importing metadata [=============] 100%                    
Resolving dependencies... done                             
Will download: 1 package (110.9 kB)                        
                                                           
  Downloading from fedora: [=============] 100%            
                                                           
Importing (1/1) [=============] 100%                       
Applying 1 overlay                                         
                                                           
Building filesystem (1/1) [=============] 100%             
Running pre scripts... 0 done                              
Running post scripts... 13 done                            
Writing rpmdb... done                                      
Writing OSTree commit... done                              
Copying /etc changes: 14 modified, 0 removed, 35 added     
Bootloader updated; bootconfig swap: yes deployment count change: 0                                                   
Added:                                                     
  htop-2.1.0-1.fc28.x86_64                                 
Run "systemctl reboot" to start a reboot                   

```

Comment 10 Mohan Boddu 2018-03-28 01:03:48 UTC
+1 FE

Comment 11 Adam Williamson 2018-03-28 01:08:32 UTC
Kevin: well, we pulled 238-5 into Beta-1.1 with pretty minimal testing (by 'we' of course I sorta mean 'I'). And that's what got us into this mess in the first place.

So what I'm saying is, pulling in 238-6 with pretty minimal testing is DEFINITELY going to be the way to get us out again. ;)

Comment 12 Adam Williamson 2018-03-28 01:26:02 UTC
That's enough votes for accepted FE. I'm going to submit a request to build a Beta-1.2 with this systemd, and the fprintd-pam change for FAW. If Beta-1.2 goes bad for some reason, we'll still have Beta-1.1 to ship instead. I won't submit systemd-238-5 *or* systemd-238-6 for stable until we're sure which we actually want to go with.

Comment 13 Zbigniew Jędrzejewski-Szmek 2018-03-28 06:37:15 UTC
FTR, this script was introduced in systemd-238-1.fc28.

We discussed this in https://github.com/systemd/systemd/pull/8550 and agreed to change to sh in Fedora for the time being.

Comment 14 Zbigniew Jędrzejewski-Szmek 2018-03-28 07:08:04 UTC
Please don't use systemd-238-6. systemd-238-7.fc28 is building now.

Comment 15 Fedora Update System 2018-03-28 16:30:08 UTC
systemd-238-7.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8082209c08

Comment 16 Fedora Update System 2018-03-28 21:09:44 UTC
systemd-238-7.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8082209c08

Comment 17 Fedora Update System 2018-03-29 19:22:24 UTC
systemd-238-7.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.