Bug 1559159

Summary: "Choose" should be shown in 'tag control' dropdown default value , instead blank is shown.
Product: Red Hat CloudForms Management Engine Reporter: Shveta <sshveta>
Component: UI - OPSAssignee: Roman Blanco <rblanco>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, hkataria, lavenel, mpovolny, obarenbo, smallamp
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1578986 (view as bug list) Environment:
Last Closed: 2019-02-11 14:09:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1578986    
Attachments:
Description Flags
dialog
none
blank default none

Description Shveta 2018-03-21 20:28:24 UTC
Created attachment 1411442 [details]
dialog

Description of problem:


Version-Release number of selected component (if applicable):
5.9.2.0.20180320210136_355c506

How reproducible:


Steps to Reproduce: 
1. Import the dialog attached .
2. Use the above imported dialog in a catalog item and order . 
3. Default selected value is blank and "Choose" is shown as one of the entries in 
the dropdown .

Actual results:


Expected results:


Additional info:

Comment 2 Shveta 2018-03-21 20:28:49 UTC
Created attachment 1411443 [details]
blank default

Comment 4 Shveta 2018-03-22 17:59:46 UTC
Correction : The dialog element is "tag control" not dropdown.

Comment 6 CFME Bot 2018-04-04 15:17:38 UTC
New commit detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/f49f9d31d94fad948e04bdf263ad68259cfa17bc
commit f49f9d31d94fad948e04bdf263ad68259cfa17bc
Author:     Roman Blanco <rblanco>
AuthorDate: Tue Apr  3 11:01:29 2018 -0400
Commit:     Roman Blanco <rblanco>
CommitDate: Tue Apr  3 11:01:29 2018 -0400

    Setting the default_value for TagControl dialog field

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1559159

    The problem is the default options Choose and None had no id, and so the default_value remained unset and so an empty option field was created. (https://stackoverflow.com/a/12654812)

    In the fix I'm setting a value of the default options to 0, and setting them as default.

 src/dialog-user/components/dialog-user/dialogField.ts | 16 +
 1 file changed, 16 insertions(+)

Comment 8 Shveta 2018-07-13 20:14:25 UTC
Fixed in 5.10.0.3.20180705151325_ce4d2b5