Bug 1559442

Summary:	Consolidated RefreshWorkers may cause job starvation
Product:	Red Hat CloudForms Management Engine	Reporter:	Tomas Coufal <tcoufal>
Component:	Providers	Assignee:	Tomas Coufal <tcoufal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tasos Papaioannou <tpapaioa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	5.8.0	CC:	cpelland, gblomqui, jfrey, jhardy, obarenbo, tpapaioa
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.10.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1560699 (view as bug list)		Environment:
Last Closed:	2019-02-11 14:06:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1560699

Description Tomas Coufal 2018-03-22 14:55:11 UTC

Description of problem:
Job starvation can occur when :drb strategy is used for RefreshWorkers


Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Start EVM
2. Add Azure or Amazon provider (any provider with consolidated workers)
3. Start queueing the provider refresh (over long period of time, in some interval shorter than the time it takes to refresh Cloud manager)

Actual results:
Refresh of dependent managers (like Network or Storage) never happens

Expected results:
Dependent managers should be refreshed in order of job arrival to MiqQueue

Additional info:
Required to be fixed by the same time as the Azure targeted refresh lands in downstream [1]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1487602

Comment 2 Tomas Coufal 2018-03-22 14:57:08 UTC

Also affects other providers with targeted refresh like OpenStack and AWS.

Fixed by PR: https://github.com/ManageIQ/manageiq/pull/17187

Comment 3 Tomas Coufal 2018-03-26 09:15:01 UTC

PR merged.

Comment 5 Tasos Papaioannou 2018-10-05 18:46:46 UTC

Verified on 5.10.0.18.