Bug 1559690

Summary: If import cluster failed, the cluster global details status should be set as unhealthy
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Shubhendu Tripathi <shtripat>
Component: web-admin-tendrl-gluster-integrationAssignee: Shubhendu Tripathi <shtripat>
Status: CLOSED ERRATA QA Contact: Filip Balák <fbalak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: dahorak, fbalak, mbukatov, nthomas, rhs-bugs, shtripat
Target Milestone: ---   
Target Release: RHGS 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tendrl-gluster-integration-1.6.1-3.el7rhgs Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-04 07:03:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1503137    

Description Shubhendu Tripathi 2018-03-23 03:07:56 UTC
Description of problem:
If there is a failed import cluster earlier for a cluster, the global details of cluster should set cluster status as unhealthy while sync.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Martin Bukatovic 2018-03-28 09:51:34 UTC
It this downstream item for this upstream issue?

https://github.com/Tendrl/ui/issues/827

Comment 3 Martin Bukatovic 2018-03-28 09:54:12 UTC
Also based on Luboš's description, I'm not sure if this behavior is correct:

> If there is a failed import cluster earlier for a cluster,
> the global details of cluster should set cluster status as unhealthy
> while sync.

Would it make more sense to have such cluster reported as unmanaged and
import-failed?

Comment 4 Shubhendu Tripathi 2018-03-28 11:53:09 UTC
>> It this downstream item for this upstream issue?
>> https://github.com/Tendrl/ui/issues/827

Not exactly, but if import has failed say due to a situation where one nodes was not able to install tendrl-gluster-integration or unable to start tendrl-gluster-integration, just because other nodes are running tendrl-gluster-integration successfully we should not mark the cluster as healthy at least. This BZ for handling that scenario actually.

>> Would it make more sense to have such cluster reported as unmanaged and
>> import-failed?

Yes with latest changes now import cluster job waits for all the nodes to finish their first round of gluster integration sync and if the same does not happen within defined time (each node we wait for around ~6 mins which is quite a huge and reasonable time) the import job is marked as failed. But if somebody looks at REST output and global details of the cluster says healthy, that also is not correct, so we are marking the cluster global details status as unhealthy here.

Hope this clarifies.

Comment 5 Martin Bukatovic 2018-03-29 13:56:11 UTC
This bug was discussed during "RHGS WA Team status meeting" on 2018-03-29.

While we should provide "unknown" state in scenario described in the BZ
instead of "unhealthy", the idea here is to improve the current implementation
without introducing another state into code, using "unhealthy" over "healthy"
(as reported now) would align better with "import-failed,unmanaged" state in
tendrl ui.

Dev team also highlighted that when import fails, the state in tendrl ui
should be reported as "?", grafana should not be avaialble.

QE team agrees that this is not a good final solution, but agrees to verify
this improvement under assumptions described above.

Comment 9 Filip Balák 2018-07-13 13:10:56 UTC
`status` in `globaldetails` is marked as `unhealthy` for failed import flows when import times out or installation repositories are unavailable. --> VERIFIED

Tested with:
tendrl-ansible-1.6.3-5.el7rhgs.noarch
tendrl-api-1.6.3-4.el7rhgs.noarch
tendrl-api-httpd-1.6.3-4.el7rhgs.noarch
tendrl-commons-1.6.3-8.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-6.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-6.el7rhgs.noarch
tendrl-node-agent-1.6.3-8.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-6.el7rhgs.noarch

Comment 11 errata-xmlrpc 2018-09-04 07:03:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616