Bug 1560199

Summary: construct/protocols/layer3/ipv6.py contains python2 style relative import
Product: [Fedora] Fedora Reporter: Corey Farrell <git>
Component: python-constructAssignee: Terje Røsten <terje.rosten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: moez.roy, terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-construct-2.5.1-16.fc27 python-construct-2.5.1-16.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-06 12:57:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Corey Farrell 2018-03-24 19:19:11 UTC
Description of problem:
construct/protocols/layer3/ipv6.py contains `from ipv4 import ProtocolEnum`.  This is incompatible with python3, it should be `from .ipv4 import ProtocolEnum`.


Version-Release number of selected component (if applicable):
2.5.1

How reproducible:
Always

Steps to Reproduce:
1. python3 -c 'import construct.protocols.layer3.ipv6'

Actual results:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/construct/protocols/layer3/ipv6.py", line 5, in <module>
    from ipv4 import ProtocolEnum
ModuleNotFoundError: No module named 'ipv4'

Expected results:
Nothing.

Additional info:
I have not posted a bug against the upstream github because the current version of construct does not contain the protocols folder.  Bug found in f26 but confirmed that it is not fixed in 'master' of https://src.fedoraproject.org/rpms/python-construct.  Bugzilla wouldn't let me select multiple versions but this is a bug in all active versions.

Comment 1 Fedora Update System 2018-05-21 10:50:45 UTC
python-construct-2.5.1-16.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6425031fb8

Comment 2 Fedora Update System 2018-05-21 10:50:52 UTC
python-construct-2.5.1-16.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9a8b2391f4

Comment 3 Fedora Update System 2018-05-21 16:35:59 UTC
python-construct-2.5.1-16.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6425031fb8

Comment 4 Fedora Update System 2018-05-21 17:16:05 UTC
python-construct-2.5.1-16.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9a8b2391f4

Comment 5 Fedora Update System 2018-06-06 12:57:59 UTC
python-construct-2.5.1-16.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2018-06-06 13:30:21 UTC
python-construct-2.5.1-16.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.