Bug 1560240

Summary:	OpenShift Logging should use the partition supplied by the user for elasticsearch persistent storage
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	RFEs	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	1.1.3.1	CC:	apinnick, bugs, lveyde, sradco, ylavi
Target Milestone:	ovirt-4.2.3	Keywords:	FutureFeature
Target Release:	---	Flags:	sradco: ovirt-4.2? lsvaty: testing_plan_complete- rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.1.4.2-1.el7ev.noarch	Doc Type:	Enhancement
Doc Text:	In this release, it is possible to configure a persistent storage partition other than the default partition (/var) for Elasticsearch, by setting a parameter in the OpenShift Ansible inventory files.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-10 06:30:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shirly Radco 2018-03-25 08:43:55 UTC

Description of problem:
If the user configured the storage partition to be different then /var the setup will not use the correct partition for elasticsearch ,this must be parameterized in the OpenShift ansible inventory files. Default can be /var.

Version-Release number of selected component (if applicable):
1.1.3.3
How reproducible:
100%

Steps to Reproduce:
1. Configure storage to be different then /var
2. Try to install OpenShift Logging.
3.

Actual results:
OpenShift Logging will try to use /var as its storage partition

Expected results:
OpenShift Logging should use the partition supplied by the user in config.yml as its storage partition.

Additional info:

Comment 1 Lukas Svaty 2018-04-12 15:36:05 UTC

The path you want to change in your patch is /var/lib not just /var

therefore setting this to /home would create /home/lib/elasticsearch while only /home/elasticsearch would be requested

Comment 2 Red Hat Bugzilla Rules Engine 2018-04-12 15:36:10 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Lukas Svaty 2018-04-12 15:36:44 UTC

Or you can rather set the full path

/var/lib/elasticsearch and not concatanate paths...

Comment 4 Yaniv Kaul 2018-04-15 06:47:01 UTC

Severity?
It missed 4.2.2 - please re-target.

Comment 5 Lukas Svaty 2018-04-19 13:27:07 UTC

# grep mounted  /etc/ovirt-engine-metrics/config.yml
ovirt_elasticsearch_mounted_storage_path: /home/es-container

on metrics-store
# grep es-container /root/ansible-inventory-o*
/root/ansible-inventory-ocp-36-aio:openshift_logging_elasticsearch_hostmount_path=/home/es-container/lib/elasticsearch
/root/ansible-inventory-ocp-39-aio:openshift_logging_elasticsearch_hostmount_path=/home/es-container/lib/elasticsearch
/root/ansible-inventory-origin-36-aio:openshift_logging_elasticsearch_hostmount_path=/home/es-container/lib/elasticsearch
/root/ansible-inventory-origin-37-aio:openshift_logging_elasticsearch_hostmount_path=/home/es-container/lib/elasticsearch
/root/ansible-inventory-origin-39-aio:openshift_logging_elasticsearch_hostmount_path=/home/es-container/lib/elasticsearch


should be just /home/es-container
ovirt-engine-metrics-1.1.4-1.el7ev.noarch

Comment 6 Lukas Svaty 2018-04-20 08:26:36 UTC

There is not QA build for this moving to MODIFIED. Shirly will this hist 4.2.3 release or should be postponed.

Comment 7 Shirly Radco 2018-04-22 12:37:39 UTC

(In reply to Lukas Svaty from comment #6)
> There is not QA build for this moving to MODIFIED. Shirly will this hist
> 4.2.3 release or should be postponed.

It will be part of 4.2.3. I missed d/s build. Its in the upstream 1.1.4.1 build.

Comment 8 Lukas Svaty 2018-04-27 07:14:37 UTC

verified in ovirt-engine-metrics-1.1.4.2-1.el7ev.noarch

Comment 9 Lukas Svaty 2018-05-07 14:08:06 UTC

Checking again with custom elasticsearch path I found that I did an error in the naming of a container, similar to the code, which caused this test-case to pass in automation.

ovirt_elasticsearch_mounted_storage_path in config: /home/es-container
actual created elasticsearch path: /home/es-containerelasticsearch
expected created elasticsearch path: /home/es-container/elasticsearch or just /home/es-container/


we are missing trailing / while concatenating the path, probably cause concatenating strings and not os.paths

ovirt-engine-metrics-1.1.4.2-1.el7ev.noarch

Comment 10 Lukas Svaty 2018-05-09 11:00:57 UTC

verification was missing the trailing /. Even that I think this should not be the case this RFE can be VERIFIED and Ill file a small bug that the paths should be specifiable without trailing /

Comment 11 Sandro Bonazzola 2018-05-10 06:30:40 UTC

This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.