Bug 1560319

Summary:	NFS client gets "Invalid argument" when writing file through nfs-ganesha with quota
Product:	[Community] GlusterFS	Reporter:	Kinglong Mee <kinglongmee>
Component:	quota	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-v4.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-20 18:02:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kinglong Mee 2018-03-26 00:03:18 UTC

Description of problem:

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:

1. With quota disabled;
nfs client mount nfs-ganesha share, and do 'll' in the testing directory.

2. Enable quota;
getfattr: Removing leading '/' from absolute path names
trusted.gfid=0xe2edaac0eca8420ebbbcba7e56bbd240
trusted.gfid2path.b3250af8fa558e66=0x39663134343566662d653530332d343831352d396635312d3236633565366332633137642f7465737466696c653932
trusted.glusterfs.quota.9f1445ff-e503-4815-9f51-26c5e6c2c17d.contri.3=0x00000000000002000000000000000001

Notice: testfile92 without trusted.pgfid xattr.

3. restart glusterfs volume by "gluster volume stop/start gvtest"
4. echo somedata > testfile92
5. ll testfile92
-rw-r--r-- 1 root root    0 Mar  6 21:43 testfile92


Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-03-26 00:08:01 UTC

REVIEW: https://review.gluster.org/19706 (quota: allow writes when with EINVAL on pgfid isnot exist) posted (#3) for review on master by Kinglong Mee

Comment 2 Worker Ant 2018-04-09 10:22:59 UTC

COMMIT: https://review.gluster.org/19706 committed in master by "Kinglong Mee" <kinglongmee> with a commit message- quota: allow writes when with EINVAL on pgfid isnot exist

NFS client gets "Invalid argument" when writing file through nfs-ganesha.

1. With quota disabled;
nfs client mount nfs-ganesha share, and do 'll' in the testing directory.

2. Enable quota;
getfattr: Removing leading '/' from absolute path names
trusted.gfid=0xe2edaac0eca8420ebbbcba7e56bbd240
trusted.gfid2path.b3250af8fa558e66=0x39663134343566662d653530332d343831352d396635312d3236633565366332633137642f7465737466696c653932
trusted.glusterfs.quota.9f1445ff-e503-4815-9f51-26c5e6c2c17d.contri.3=0x00000000000002000000000000000001

Notice: testfile92 without trusted.pgfid xattr.

3. restart glusterfs volume by "gluster volume stop/start gvtest"
4. echo somedata > testfile92
5. ll testfile92
-rw-r--r-- 1 root root    0 Mar  6 21:43 testfile92

BUG: 1560319
Change-Id: Iaa4dd1e891c99069fb85b7b11bb0482cbf2303b1
fixes: bz#1560319
Signed-off-by: Kinglong Mee <mijinlong>

Comment 3 Worker Ant 2018-04-09 12:41:44 UTC

REVIEW: https://review.gluster.org/19837 (storage/posix: add pgfid in readdirp if needed) posted (#1) for review on master by Kinglong Mee

Comment 4 Worker Ant 2018-04-11 04:48:58 UTC

COMMIT: https://review.gluster.org/19837 committed in master by "Kinglong Mee" <kinglongmee> with a commit message- storage/posix: add pgfid in readdirp if needed

Change-Id: I6745428fd9d4e402bf2cad52cee8ab46b7fd822f
fixes: bz#1560319
Signed-off-by: Kinglong Mee <mijinlong>

Comment 5 Atin Mukherjee 2018-04-18 02:45:07 UTC

I'm moving this back to POST as this patch is causing failures of tests/features/trash.t in upstream CI. I'm going to mark the trash.t bad with this same bug id till this is addressed. Given we're nearing GlusterFS 4.1 branching, lot of critical patches are stuck in regression pipeline queue and we need to make a move on.

Comment 6 Worker Ant 2018-04-18 02:49:01 UTC

REVIEW: https://review.gluster.org/19894 (tests: mark trash.t as bad) posted (#1) for review on master by Atin Mukherjee

Comment 7 Worker Ant 2018-04-18 05:11:15 UTC

REVIEW: https://review.gluster.org/19896 (Revert \"storage/posix: add pgfid in readdirp if needed\") posted (#1) for review on master by Nigel Babu

Comment 8 Worker Ant 2018-04-18 05:11:52 UTC

COMMIT: https://review.gluster.org/19896 committed in master by "Nigel Babu" <nigelb> with a commit message- Revert "storage/posix: add pgfid in readdirp if needed"

This reverts commit d206fab73f6815c927a84171ee9361c9b31557b1.

Change-Id: I5b43fdcf916bc844437c9d60f6957bc40936e3c2
Updates: bz#1560319
Signed-off-by: Nigel Babu <nigelb>

Comment 9 Shyamsundar 2018-06-20 18:02:52 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/