Bug 1560845

Checking what sos collects now (*), my understanding is you should rather require logs from some subdirectory like /var/log/containers/openvswitch or similar?

Since the directory /var/log/containers can have very rich content, much of it irrelevant to openvswitch, I expect.

(*) https://github.com/sosreport/sos/search?utf8=%E2%9C%93&q=%22%2Fvar%2Flog%2Fcontainers%22&type=

Further, like in bz1560849, is whole directory /var/log/containers/{some-subdir?} required to collect, or is it sufficient to:

- collect /var/log/containers/{some-subdir?}*.log by default
- if --all-logs option provided, whole dir collected

?

(and again, automatic prerequisite to collect these logs will be presence of openvswitch or openvswitch-dpdk package, I assume)

(In reply to Pavel Moravec from comment #5)
> Checking what sos collects now (*), my understanding is you should rather
> require logs from some subdirectory like /var/log/containers/openvswitch or
> similar?
> 
> Since the directory /var/log/containers can have very rich content, much of
> it irrelevant to openvswitch, I expect.
> 
> (*)
> https://github.com/sosreport/sos/
> search?utf8=%E2%9C%93&q=%22%2Fvar%2Flog%2Fcontainers%22&type=
> 
> Further, like in bz1560849, is whole directory
> /var/log/containers/{some-subdir?} required to collect, or is it sufficient
> to:
> 
> - collect /var/log/containers/{some-subdir?}*.log by default
> - if --all-logs option provided, whole dir collected
> 
> ?
> 
> (and again, automatic prerequisite to collect these logs will be presence of
> openvswitch or openvswitch-dpdk package, I assume)

When I enter to my setup I see the openvswitch logs under  var/log/containers/openvswitch, my expectation is when I  collect the logs with sos report I will see the logs with the same path of : var/log/containers/openvswitch

(In reply to Eran Kuris from comment #6)
> (In reply to Pavel Moravec from comment #5)
> > Checking what sos collects now (*), my understanding is you should rather
> > require logs from some subdirectory like /var/log/containers/openvswitch or
> > similar?
> > 
> > Since the directory /var/log/containers can have very rich content, much of
> > it irrelevant to openvswitch, I expect.
> > 
> > (*)
> > https://github.com/sosreport/sos/
> > search?utf8=%E2%9C%93&q=%22%2Fvar%2Flog%2Fcontainers%22&type=
> > 
> > Further, like in bz1560849, is whole directory
> > /var/log/containers/{some-subdir?} required to collect, or is it sufficient
> > to:
> > 
> > - collect /var/log/containers/{some-subdir?}*.log by default
> > - if --all-logs option provided, whole dir collected
> > 
> > ?
> > 
> > (and again, automatic prerequisite to collect these logs will be presence of
> > openvswitch or openvswitch-dpdk package, I assume)
> 
> When I enter to my setup I see the openvswitch logs under 
> var/log/containers/openvswitch, my expectation is when I  collect the logs
> with sos report I will see the logs with the same path of :
> var/log/containers/openvswitch

Thanks for clarification. 

Wrt. bz1560849 / PR1259 I forgot to ask: when these logs shall be automatically collected? Presence of what package should trigger those logs collection? (or in sos terminology: what plugin should collect them)?

- plugin openvswitch is automatically enabled by presence of either 'openvswitch', or 'openvswitch-dpdk' package
- proposed plugin ovn_central will be automatically enabled by presence of openvswitch-ovn-central package
- proposed plugin ovn_host will be automatically enabled by presence of openvswitch-ovn-host package

What package / plugin is responsible for the (container) logs, please?

Numan can you answer that ^ 
I am not sure about it.

Just to clarify, what we need is that the OVN sosreport plugin collects the logs from [0] (which defaults to /var/log/containers/openvswitch).

[0] https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/pacemaker/ovn_dbs_bundle.pp#L130

(In reply to Pavel Moravec from comment #7)
> (In reply to Eran Kuris from comment #6)
> > (In reply to Pavel Moravec from comment #5)
> > > Checking what sos collects now (*), my understanding is you should rather
> > > require logs from some subdirectory like /var/log/containers/openvswitch or
> > > similar?
> > > 
> > > Since the directory /var/log/containers can have very rich content, much of
> > > it irrelevant to openvswitch, I expect.
> > > 
> > > (*)
> > > https://github.com/sosreport/sos/
> > > search?utf8=%E2%9C%93&q=%22%2Fvar%2Flog%2Fcontainers%22&type=
> > > 
> > > Further, like in bz1560849, is whole directory
> > > /var/log/containers/{some-subdir?} required to collect, or is it sufficient
> > > to:
> > > 
> > > - collect /var/log/containers/{some-subdir?}*.log by default
> > > - if --all-logs option provided, whole dir collected
> > > 
> > > ?
> > > 
> > > (and again, automatic prerequisite to collect these logs will be presence of
> > > openvswitch or openvswitch-dpdk package, I assume)
> > 
> > When I enter to my setup I see the openvswitch logs under 
> > var/log/containers/openvswitch, my expectation is when I  collect the logs
> > with sos report I will see the logs with the same path of :
> > var/log/containers/openvswitch
> 
> Thanks for clarification. 
> 
> Wrt. bz1560849 / PR1259 I forgot to ask: when these logs shall be
> automatically collected? Presence of what package should trigger those logs
> collection? (or in sos terminology: what plugin should collect them)?
> 
> - plugin openvswitch is automatically enabled by presence of either
> 'openvswitch', or 'openvswitch-dpdk' package
> - proposed plugin ovn_central will be automatically enabled by presence of
> openvswitch-ovn-central package
> - proposed plugin ovn_host will be automatically enabled by presence of
> openvswitch-ovn-host package
> 
> What package / plugin is responsible for the (container) logs, please?

Sorry for the late response.

I would say the propose plugin ovn_central should also collect the container logs (when openvswitch-ovn-central package) is enabled. I am not sure if proposed ovn_central plugin is doing it.

The pull request here [1] which adds the ovn_central plugin does collect the logs as well.

[1] - https://github.com/sosreport/sos/pull/1259/files

For 7.5.2: 
- GSSApproved for the z-stream

- please confirm OtherQE / somebody from OSP / OVN people will verify the sos build once ready
(as 2 plugins would be backported whereas they provide bit more functionality beyond RHEL platform what would need more time to our QE to verify it)

(In reply to Pavel Moravec from comment #16)
> For 7.5.2: 
> - GSSApproved for the z-stream
> 
> - please confirm OtherQE / somebody from OSP / OVN people will verify the
> sos build once ready
> (as 2 plugins would be backported whereas they provide bit more
> functionality beyond RHEL platform what would need more time to our QE to
> verify it)

Once the fix will be part of OSP puddle I will verify the issue.

*** Bug 1560849 has been marked as a duplicate of this bug. ***

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:3144