Bug 1561080
| Summary: | [downstream clone - 4.1.11] MacPool fails to initialize when it contains duplicates and user disallows duplicates | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | RHV bug bot <rhv-bugzilla-bot> |
| Component: | ovirt-engine | Assignee: | eraviv |
| Status: | CLOSED ERRATA | QA Contact: | Michael Burman <mburman> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 4.1.9 | CC: | bgraveno, danken, eraviv, gveitmic, lsurette, mburman, rbalakri, Rhev-m-bugs, srevivo, ykaul, ylavi |
| Target Milestone: | ovirt-4.1.11 | Keywords: | ZStream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
This update prevents the user from clearing the "Allow Duplicates" check box in the Edit MAC Address Pool dialog or via a corresponding REST request if duplicate MAC addresses exist.
|
Story Points: | --- |
| Clone Of: | 1554180 | Environment: | |
| Last Closed: | 2018-04-24 15:30:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1554180, 1561865 | ||
| Bug Blocks: | |||
|
Description
RHV bug bot
2018-03-27 15:07:13 UTC
Just to document here the way out of this: 1) reinitialize engine (thankfully allow duplicate macs is still enabled in the DB), so macpool will initialize fine if we restart the engine. 2) remove duplicate mac To find them: /usr/share/ovirt-engine/dbscripts/engine-psql.sh -c "select vm_static.vm_name,mac_addr,creation_date from vm_interface,vm_static where vm_interface.vm_guid = vm_static.vm_guid and mac_addr in (select mac_addr from vm_interface group by mac_addr having (count(*) >1)) order by mac_addr;" 3) uncheck allow duplicates (Originally by Germano Veit Michel) (In reply to Germano Veit Michel from comment #1) > Just to document here the way out of this: > > 1) reinitialize engine (thankfully allow duplicate macs is still enabled in > the DB), so macpool will initialize fine if we restart the engine. > > 2) remove duplicate mac > To find them: > /usr/share/ovirt-engine/dbscripts/engine-psql.sh -c "select > vm_static.vm_name,mac_addr,creation_date from vm_interface,vm_static where > vm_interface.vm_guid = vm_static.vm_guid and mac_addr in (select mac_addr > from vm_interface group by mac_addr having (count(*) >1)) order by mac_addr;" Can you contribute this script? > > 3) uncheck allow duplicates (Originally by Yaniv Kaul) (In reply to Yaniv Kaul from comment #3) > Can you contribute this script? This was already contributed in a much better form here as a tool to detect and fix duplicate macs: https://gerrit.ovirt.org/#/c/83415/ Looks like it may ship with 4.3 if it gets merged someday. Or do you have something else in mind where such logic would be useful? (Originally by Germano Veit Michel) (In reply to Germano Veit Michel from comment #4) > This was already contributed in a much better form here as a tool to detect > and fix duplicate macs: https://gerrit.ovirt.org/#/c/83415/ > Looks like it may ship with 4.3 if it gets merged someday. We can merge and ship your script even earlier, but it needs to be Verfied+1, CI+1 (and make sure it is really shipped in ovirt-engine.rpm) (Originally by danken) *** Bug 1561081 has been marked as a duplicate of this bug. *** As Eitan wrote in BZ 1554180 comment10# "http://gerrit.ovirt.org/89578 is not strictly required to make sure this bug does not reproduce. The 4.2.2-merged validation patch http://gerrit.ovirt.org/89513 is enough for that. This bug can, and should be, tested by QA now." Based on this, testing - Validation is added when trying to unset the 'Allow Duplicates' when MAC pool contains duplicate MACs. 'Error while executing action: Cannot edit MAC Pool. Cannot unset 'Allow Duplicates' when mac pool contains duplicate macs.' Bug can't reproduced. No regression introduced. After removing the duplicate MAC and unsettling the 'Allow Duplicates' , engine behaves as expected. Verified on - 4.1.11.1-0.1.el7 Eitan, I don't think that BZ 1561865 should be a blocker to this bug and it's any how targeted only for 4.2 And also, i think that the summary/title of this bug and BZ 1554180 should be changed according to actual change that was done, the validation of duplicate MACs in the pool that was added. Thanks, Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1219 Added description in Added description in doc text. BZ<2>Jira Resync |