Bug 1561308

Summary: SDL_sound: enable MP3 support
Product: [Fedora] Fedora Reporter: Yaakov Selkowitz <yselkowi>
Component: SDL_soundAssignee: Hans de Goede <hdegoede>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: hdegoede, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: SDL_sound-1.0.3-21.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-02 11:47:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 182235    
Attachments:
Description Flags
Patch for rawhide none

Description Yaakov Selkowitz 2018-03-28 04:48:30 UTC
The Fedora sources for SDL_sound have been stripped to exclude the bundled mpglib, which provides MP3 support.  Now that MP3 is considered unencumbered, I believe the original sources can be used (or, at least, not strip decoders/mpglib) and configured with --enable-mpglib.

Comment 1 Yaakov Selkowitz 2018-03-28 04:51:40 UTC
Created attachment 1413966 [details]
Patch for rawhide

F27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26013185

Scratch build for F28+ was not done due to bug 1555579.

Comment 2 Yaakov Selkowitz 2018-03-28 06:21:57 UTC
Upon further testing, it seems this MP3 support is rather limited.  While better than nothing, we would be better off using SMPEG if we can get it approved.

Comment 3 Hans de Goede 2018-03-28 10:55:14 UTC
Hi,

Thank you for the bug report. For now I've gone ahead and enabled the mpglib based mp3 support, since I needed to do an update to fix the FTBFS anyways.

If you want to ask Fedora-legal if SMPEG is ok for Fedora now, go ahead. I do not have time to pursue this.

Regards,

Hans

Comment 4 Fedora Update System 2018-03-28 11:30:01 UTC
SDL_sound-1.0.3-21.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c508c4f5a6

Comment 5 Fedora Update System 2018-03-28 21:11:55 UTC
SDL_sound-1.0.3-21.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c508c4f5a6

Comment 6 Fedora Update System 2018-04-02 11:47:43 UTC
SDL_sound-1.0.3-21.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.