Bug 1561337

Summary:	gpsbabel versions 1.5.0 through 1.5.4: geo.cc only handles integer terrain or difficulty
Product:	[Fedora] Fedora	Reporter:	Rick Richardson <rickrich>
Component:	gpsbabel	Assignee:	Ralf Corsepius <rc040203>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	26	CC:	cse.cem+redhatbugz, davejohansen, itamar, rc040203, rhbugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gpsbabel-1.5.4-9.fc28 gpsbabel-1.5.4-9.fc26 gpsbabel-1.5.4-9.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-09 13:24:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rick Richardson 2018-03-28 06:57:32 UTC

See http://geo.rkkda.com/forum/read.php?8,1069 for details.

It used to work in 1.4.4, before the "C" language gpsbabel got refactored into "C++" language gpsbabel.

Basically, the floating point does not work if the decimal part is non-zero. E.G. 3.0 goes to 3.0, but 3.5 goes to 0.0!

$ cd gpsbabel

$ diff -u geo.cc.org geo.cc
--- geo.cc.org  2017-10-14 20:54:31.228998156 -0500
+++ geo.cc      2017-10-14 20:55:48.450485105 -0500
@@ -74,9 +74,9 @@
         waypt_add_url(wpt,
                       reader.readElementText(), a.value("text").toString());
       } else if (current_tag == "/loc/waypoint/difficulty") {
-        wpt->gc_data->diff = reader.readElementText().toInt() * 10;
+        wpt->gc_data->diff = reader.readElementText().toDouble() * 10;
       } else if (current_tag == "/loc/waypoint/terrain") {
-        wpt->gc_data->terr = reader.readElementText().toInt() * 10;
+        wpt->gc_data->terr = reader.readElementText().toDouble() * 10;
       } else if (current_tag == "/loc/waypoint/container") {
         wpt->gc_data->container = wpt_container(reader.readElementText());
       }


"Thanx for the fix, Rick. It's going into https://github.com/gpsbabel/gpsbabel/pull/93 " - Robert Lipe

Unfortunately, gpsbabel is still on 1.5.4, even after I reported this in October 14, 2017.

Comment 1 Conrad Meyer 2018-03-28 15:02:12 UTC

Yeah, the gpsbabel folks can be fairly slow to push out releases, unfortunately.

Comment 2 Conrad Meyer 2018-03-28 15:21:55 UTC

Apparently I lost commit permissions to this package.  Here's a PR:

https://src.fedoraproject.org/rpms/gpsbabel/pull-request/1

Comment 3 Fedora Update System 2018-04-03 09:42:31 UTC

gpsbabel-1.5.4-9.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e714994253

Comment 4 Fedora Update System 2018-04-03 09:42:42 UTC

gpsbabel-1.5.4-9.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-59f23b3da0

Comment 5 Fedora Update System 2018-04-03 09:42:49 UTC

gpsbabel-1.5.4-9.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f0f265d193

Comment 6 Fedora Update System 2018-04-03 15:25:28 UTC

gpsbabel-1.5.4-9.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f0f265d193

Comment 7 Fedora Update System 2018-04-03 15:52:45 UTC

gpsbabel-1.5.4-9.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-59f23b3da0

Comment 8 Fedora Update System 2018-04-03 15:59:11 UTC

gpsbabel-1.5.4-9.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e714994253

Comment 9 Rick Richardson 2018-04-05 02:52:28 UTC

Thanks! Put in the testing fc26 gpsbabel and it works!

Before:
$ geo-nearest -otabsep
19      GC637Z0 If Only Stones Could Float!?! by JAYMZ*BRONX            http://www.geocaching.com/seek/cache_details.aspx?log=y&wp=GC637Z0              Geocache-regular        44.935100       -93.499833      1770540707      1363150200      44.935100N      93.499833W      N44.935100      W93.499833      N       W       -328083986.719160F      -99999999.000000M       42257.208333    1441861200      2.0     0.0     Small   Traditional Cache       19.949596       32.105762       JAYMZ*BRONX     20150910        hint    20161114


After:
$ geo-nearest -otabsep
...
19      GC637Z0 If Only Stones Could Float!?! by JAYMZ*BRONX            http://www.geocaching.com/seek/cache_details.aspx?log=y&wp=GC637Z0              Geocache-regular        44.935100       -93.499833      1770540707      1363150200      44.935100N      93.499833W      N44.935100      W93.499833      N       W       -328083986.719160F      -99999999.000000M       42257.208333    1441861200      2.0     2.5     Small   Traditional Cache       19.949596       32.105762       JAYMZ*BRONX     20150910        hint    20161114

Comment 10 Fedora Update System 2018-04-09 13:24:58 UTC

gpsbabel-1.5.4-9.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-04-18 01:03:09 UTC

gpsbabel-1.5.4-9.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-04-18 01:22:36 UTC

gpsbabel-1.5.4-9.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.