Bug 1561447

Summary:	VM with a lease manage to remove while the VM lease storage domain is not active
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Evelina Shames <eshames>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	bugs, ebenahar, eshenitz, tnisan, ylavi
Target Milestone:	ovirt-4.2.3	Flags:	rule-engine: ovirt-4.2+ ylavi: exception+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	VM with a lease on a non-active storage domain will fail to remove. The VM will remove when the VM lease storage domain is active as similar to disks behavior. A workaround is to remove the VM lease in "Edit VM" and then try to remove again, same as we can detach disks from VM even if the storage is down	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-10 06:34:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2018-03-28 11:01:09 UTC

Description of problem:

When having a VM with a lease, the VM managed to remove from the data center even though the VM lease storage domain was on maintenance.

As similar to disks, when one of the storage domain that contains one of the VM disks is not active, the VM cannot be removed.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM with a disk based on storage domain [A] and a lease based on storage domain [B]
2. Deactivate storage domain [B]
3. Remove the VM

Actual results:
The VM removed from the environment

Expected results:
The VM removal should be banned by an engine validation

Additional info:

Comment 1 Eyal Shenitzky 2018-03-28 11:01:52 UTC

version - 4.3.0_master - from commit 431feb88ac66840b6ce62237f9219f4e89af1c4b

Comment 2 Sandro Bonazzola 2018-04-18 11:08:08 UTC

All referenced patches are in merged state, should this move to modified?

Comment 3 Evelina Shames 2018-04-24 13:05:47 UTC

Verified.
Engine: 4.2.3.2-0.1

Comment 4 Sandro Bonazzola 2018-05-10 06:34:09 UTC

This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.