Bug 1562044
| Summary: | authconfig --savebackup no longer takes a path | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Heimes <cheimes> |
| Component: | authselect | Assignee: | Pavel Březina <pbrezina> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | cheimes, jlieskov, pbrezina, tmraz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | authselect-0.4-1.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 22:58:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christian Heimes
2018-03-29 12:32:24 UTC
I just noticed that savebackup isn't supported at all: # authconfig --savebackup Running authconfig compatibility tool. IMPORTANT: authconfig is replaced by authselect, please update your scripts. See Fedora 28 Change Page: https://fedoraproject.org/wiki/Changes/AuthselectAsDefault See man authselect-migration(7) to help you with migration to authselect Warning: These options are not supported anymore and have no effect: --savebackup Error: Please, provide --updateall option. I have created https://github.com/freeipa/freeipa/pull/1760 to temporarily disable backup and restore of auth config data. I fixed --savebackup and --restorebackup so it takes a path and does not broken execution [1]. I also have a patch ready, that will make authconfig exit with 0 instead of 1 if you provide or --restorebackup --restorelastbackup so it will not fail script execution [2]. The purpose of compat utility is to make authentication work if it is used in kickstart/installation scripts. It is not desirable to implement all authconfig features and backup/restore was one of the feature that did not go in because it should not be needed when installing the system. Authselect itself will not do any modifications to non-authselect system unless --force parameter and once it is used, administrator is not supposed to modify the configuration manually. So backup/restore is not strictly needed here. Since you will switch to authselect and thus not relying on authconfig backup anymore, will [2] be enough to fix this issue and enable testing or do you require to actually implement backup and restore support? [1] https://github.com/pbrezina/authselect/commit/c57d22bcb377000c04269d691cd752e8eaa956e9 [2] https://github.com/pbrezina/authselect/commit/a0a10c4cf9551080c820325953ea93a849b54122 I added a workaround to FreeIPA master and disabled authconfig save/restore backup feature temporarily. FreeIPA development is no longer blocked by the issue. We'll move to authselect soon, too. The PR is still under development. Your patch [1] is a good idea. Patch [2] is no longer required for FreeIPA development. I don't like it, too. The compat authconfig command should fail with a proper error code. authselect-0.4-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d5f37ac141 authselect-0.4-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d5f37ac141 authselect-0.4-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |