Bug 1562278

Summary: zram.service is not enabled on LiveOS
Product: [Fedora] Fedora Reporter: Chris Murphy <bugzilla>
Component: LiveCDAssignee: Matthias Clasen <mclasen>
Status: CLOSED EOL QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: anaconda-maint-list, bugzilla, debarshir, jonathan, kellin, mattdm, mcatanzaro+wrong-account-do-not-cc, pablodav, trailtotale, vanmeeuwen+fedora, v.podzimek+fedora, vponcova, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-27 19:45:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1517012    

Description Chris Murphy 2018-03-30 01:15:30 UTC
Description of problem:

On netinstall and dvd Fedora ISO install media, zram.service is enabled by default. On LiveOS it's not, but probably would benefit from it.

Version-Release number of selected component (if applicable):
Fedora-Workstation-Live-x86_64-28_Beta-1.1.iso
anaconda 28.22.2-7.fc28

How reproducible:
Always

Steps to Reproduce:
1. Boot Fedora-Workstation-Live-x86_64-28_Beta-1.1.iso
2. systemctl status zram.service
3.

Actual results:

   Loaded: loaded (/usr/lib/systemd/system/zram.service; static; vendor preset: disabled)


Expected results:

Maybe add a line to the service

ConditionKernelCommandLine=rd.live.image

This makes sure it's only triggered on live boots not on installed systems?


Additional info:

Comment 1 Chris Murphy 2018-09-15 18:09:47 UTC
This really should be enabled. Depending on OOM killer in low memory situations is definitely resulting in a bad experience. This service is enabled by default on netinstalls, but for some reason not lives, and it's even more needed for lives which have a much higher memory footprint.

Comment 2 Fedora Blocker Bugs Application 2018-09-17 19:30:21 UTC
Proposed as a Freeze Exception for 29-beta by Fedora user chrismurphy using the blocker tracking app because:

 In low memory (2GB or less) situations it substantially improves the experience with better performance and far less likely OOM killer instances.

zram.service is enabled on netinstall since at least Fedora 28; and I've been testing it in lives by manually starting it, since Fedora 28. So I'm confident this is safe. This FE request is only to enable zram.service in lives, ensuring it is not enabled on installed systems.

Workstation WG issue:
https://pagure.io/fedora-workstation/issue/75

Comment 3 Chris Murphy 2018-09-17 20:01:29 UTC
Although I am +1 FE, I'm confident enough in the behavior of zram.service that we don't really need wide spread beta testing, but it can't hurt to do so.

Summary for the blocker/FE review:

Install environments typically have no swap available until the installer creates and activates it *after* "Begin Installation" is clicked. The zram.service creates a RAM drive that uses LZ4 compression, as swap. The service setup is all user space driven, but the zram block device code is all in the kernel including dynamic allocation, meaning other than 0.1% overhead for creating the zram device, it doesn't actually use any memory until something uses it (i.e. swap is needed).

Further, this does not actually change anything in the installer, it's just that anaconda owns the zram.service and zramswapon scripts that set this up. In fact it will be systemd that will start the service during startup.

Comment 4 Vendula Poncova 2018-09-18 12:57:18 UTC
Anaconda is not responsible for starting the zram.service in Live OS. However, it might be enough to update the kickstart file for Fedora Live Workstation. Reassigning to LiveCD.

Comment 5 Ben Cotton 2019-10-31 20:34:27 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Ben Cotton 2019-11-27 19:45:06 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 7 Michael Catanzaro 2019-11-27 20:21:53 UTC
...Chris, status update?