Bug 1562611
Summary: | Review Request: golang-github-jbenet-context - Go context.Context extensions | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-04-02 23:45:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dominik 'Rathann' Mierzejewski
2018-04-01 12:45:31 UTC
Description: Package context contains some extensions to go.net/context by @jbenet. - Fix the Release in your %changelog entry: * Sun Apr 01 2018 Dominik Mierzejewski <dominik> - 0-0.1.20180401gitd14ea06 - Seems you're missing a BR for the tests: + go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\''' BUILDSTDERR: dagctx.go:7:2: cannot find package "golang.org/x/net/context" in any of: BUILDSTDERR: /usr/lib/golang/src/golang.org/x/net/context (from $GOROOT) BUILDSTDERR: /builddir/build/BUILD/go-context-d14ea06fba99483203c19d92cfcd13ebe73135f4/_build/src/golang.org/x/net/context (from $GOPATH) BUILDSTDERR: /usr/share/gocode/src/golang.org/x/net/context Add: BuildRequires: golang(golang.org/x/net/context) You're right, just found out myself when I saw the failed COPR build. Fixed: Spec URL: https://rathann.fedorapeople.org/review/golang-github-jbenet-context/golang-github-jbenet-context.spec SRPM URL: https://rathann.fedorapeople.org/review/golang-github-jbenet-context/golang-github-jbenet-context-0-0.2.20180401gitd14ea06.fc27.src.rpm * Mon Apr 02 2018 Dominik Mierzejewski <dominik> - 0-0.2.20180401gitd14ea06 - add missing BuildRequires - fix Release in changelog entries All ok, package approved. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jbenet-context Imported and built for rawhide. Thanks for the review! |