Bug 1562940

Summary: Regression Custom Button Dialog Not Displaying Submit or Cancel Button
Product: Red Hat CloudForms Management Engine Reporter: myoder
Component: UI - OPSAssignee: eclarizi
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, hkataria, lavenel, mpovolny, obarenbo, pmcgowan
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1565151 (view as bug list) Environment:
Last Closed: 2019-02-11 14:03:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1565151    
Attachments:
Description Flags
VM Template button no submit
none
Container Node has submit button none

Description myoder 2018-04-02 17:34:05 UTC 
Description of problem:

Created a custom button for VM Templates, and when I navigate to the custom button, there is no submit or cancel button.


Version-Release number of selected component (if applicable):
CFME 5.9

How reproducible:
always

Steps to Reproduce:
1. Create a dialog
2. Create a VM Template Custom Button
3. Navigate to a template and click the custom button

Actual results:
There are no submit or cancel buttons

Expected results:
There should be a submit or cancel button

Additional info:
I found this bug that has the same issue with service catalogs:

  https://bugzilla.redhat.com/show_bug.cgi?id=1515322


Also, I was able to get a custom button to display the submit and cancel buttons for Container Node button.  I noticed the editor was different for the Container Node than what was being displayed for the VM Template.  Looks like the same case as the old dialog editor being used for the VM Template custom button.
Comment 2 myoder 2018-04-02 17:37:34 UTC 
Created attachment 1416428 [details]
VM Template button no submit
Comment 3 myoder 2018-04-02 17:38:00 UTC 
Created attachment 1416429 [details]
Container Node has submit button
Comment 6 CFME Bot 2018-04-03 18:16:39 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/3713
Comment 7 CFME Bot 2018-04-03 18:17:00 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/3712
Comment 8 CFME Bot 2018-04-04 13:46:49 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b9bc280a952070320082fcad0ce530e8a56aa715
commit b9bc280a952070320082fcad0ce530e8a56aa715
Author:     Erik Clarizio <eclarizio>
AuthorDate: Tue Apr  3 13:57:57 2018 -0400
Commit:     Erik Clarizio <eclarizio>
CommitDate: Tue Apr  3 13:57:57 2018 -0400

    Adjust target type for Template custom buttons

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562940

 app/controllers/vm_common.rb | 6 +-
 app/services/dialog_local_service.rb | 19 +-
 spec/services/dialog_local_service_spec.rb | 4 +-
 3 files changed, 21 insertions(+), 8 deletions(-)
Comment 10 Yadnyawalk Tale 2018-10-03 17:05:16 UTC 
Fixed! Verified on: 5.10.0.17.20180927011235_1b5cf54