Bug 1563184
| Summary: | Review Request: rpkg-util - RPM packaging utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | clime |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | msuchy, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-09-08 14:47:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
clime
2018-04-03 11:28:40 UTC
Taking this review. Package build fails on %check section: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.oJ7Crn + umask 022 + cd /builddir/build/BUILD + cd rpkg-util-1.0.git.198.d77c2b9 + FULL=1 + ./run_tests.sh ============================= test session starts ============================== platform linux2 -- Python 2.7.14, pytest-3.4.2, py-1.5.3, pluggy-0.6.0 rootdir: /builddir/build/BUILD/rpkg-util-1.0.git.198.d77c2b9, inifile: collected 29 items BUILDSTDERR: tests/test_cli.py .This function is deprecated and will be removed in a future release. BUILDSTDERR: .This function is deprecated and will be removed in a future release. BUILDSTDERR: ..Auto-packing is deprecated and will be removed in a future release. BUILDSTDERR: .....This function is deprecated and will be removed in a future release. BUILDSTDERR: This function is deprecated and will be removed in a future release. . BUILDSTDERR: tests/test_cmd.py ..........error: Package has no %description: testpkg ....... tests/test_lookaside.py . tests/test_utils.py . ========================== 29 passed in 0.83 seconds =========================== ====================== test_bash ====================== Initialized empty Git repository in /tmp/tmp.AnQ2iUXGBa/.git/ > ../preproc.py --path /tmp/tmp.AnQ2iUXGBa --input /tmp/tmp.AnQ2iUXGBa/input --output /tmp/tmp.wkDoLIha3j/output | log_filter &> /tmp/tmp.wkDoLIha3j/log > diff /tmp/tmp.CNJEmyUSlI /tmp/tmp.wkDoLIha3j/output || die 3c3 < date --date='@2147483647' +%y%m%d: 380119 --- > date --date='@2147483647' +%y%m%d: 380118 fail. BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check) RPM build errors: BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check) Child return code was: 1 Spec URL: https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00738939-rpkg-util/rpkg-util.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00738939-rpkg-util/rpkg-util-1.0.git.231.febc6f2-1.fc29.src.rpm Can you re-review, please? Review notes:
[x] Package is named appropriately
[x] Licensing is correctly noted and license files are correctly installed
[x] Packaging follows Fedora Python Packaging Guidelines
[!] Packaging follows Fedora Packaging Guidelines
* VCS tag is used, Source0 isn't verifiable
* Version scheme doesn't follow current snapshot release guidelines
Spec URL: https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00739073-rpkg-util/rpkg-util.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00739073-rpkg-util/rpkg-util-1.0-1.fc29.src.rpm ...fixes according to the review notes. ping. Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get the tarball. (In reply to Neal Gompa from comment #7) > Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get > the tarball. I haven't found any mention in guidelines of VCS tag being forbidden. I believe it's ok to use it as a tag describing upstream source for the package. Using non-url Source0 should be also alright as described here: https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control Comments how to obtain the Source0 were added. (In reply to clime from comment #8) > (In reply to Neal Gompa from comment #7) > > Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get > > the tarball. > > I haven't found any mention in guidelines of VCS tag being forbidden. I > believe it's ok to use it as a tag describing upstream source for the > package. > > Using non-url Source0 should be also alright as described here: > > https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control > > Comments how to obtain the Source0 were added. Also...as you can see... https://releases.pagure.org/rpkg-util upstream does not provide source tarball *shrugs*. Neal, can your objections be satisfied by specific pointers into Fedora Packaging Guidelines? If not, I don't really see why not continue. So, please, express your take on this because I would like to move it forward. Well, there's nothing else left, I suppose... Please work with upstream to resolve missing tarballs and switch to that. Otherwise... APPROVED. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rpkg-util |