Bug 1563611

Summary: Review Request: perl-Path-Tiny-Rule - Path::Iterator::Rule subclass that returns Path::Tiny objects
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Path-Tiny-Rule-0.01-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-05 06:52:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1563433    

Description Jitka Plesnikova 2018-04-04 10:08:44 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Path-Tiny-Rule/perl-Path-Tiny-Rule.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Path-Tiny-Rule/perl-Path-Tiny-Rule-0.01-1.fc29.src.rpm

Description:
This module is a very thin wrapper around Path::Iterator::Rule that
always returns Path::Tiny objects instead of strings. It should otherwise
be a drop-in replacement for Path::Iterator::Rule, and any deviation from
that is a bug.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2018-04-04 11:00:24 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: ef101325a72b7e8475923bde09b153c268584cbe7d1819af5558b072925cf69f) is original. Ok.
Summary is Ok.
Description is Ok.
License verified from lib/Path/Tiny/Rule.pm, LICENSE, and README.md. Ok.
No XS code, noarch BuildArch is Ok.
Build requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Path-Tiny-Rule.spec ../SRPMS/perl-Path-Tiny-Rule-0.01-1.fc29.src.rpm ../RPMS/noarch/perl-Path-Tiny-Rule-0.01-1.fc29.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Path-Tiny-Rule-0.01-1.fc29.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Apr  4 12:54 /usr/share/doc/perl-Path-Tiny-Rule
-rw-r--r--    1 root    root                     4160 Nov  5 03:27 /usr/share/doc/perl-Path-Tiny-Rule/CONTRIBUTING.md
-rw-r--r--    1 root    root                       65 Nov  5 03:27 /usr/share/doc/perl-Path-Tiny-Rule/Changes
-rw-r--r--    1 root    root                     2524 Nov  5 03:27 /usr/share/doc/perl-Path-Tiny-Rule/README.md
drwxr-xr-x    2 root    root                        0 Apr  4 12:54 /usr/share/licenses/perl-Path-Tiny-Rule
-rw-r--r--    1 root    root                     9040 Nov  5 03:27 /usr/share/licenses/perl-Path-Tiny-Rule/LICENSE
-rw-r--r--    1 root    root                     2247 Apr  4 12:54 /usr/share/man/man3/Path::Tiny::Rule.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr  4 12:54 /usr/share/perl5/vendor_perl/Path
drwxr-xr-x    2 root    root                        0 Apr  4 12:54 /usr/share/perl5/vendor_perl/Path/Tiny
-rw-r--r--    1 root    root                     2763 Nov  5 03:27 /usr/share/perl5/vendor_perl/Path/Tiny/Rule.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Path-Tiny-Rule-0.01-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(namespace::autoclean)
      1 perl(parent)
      1 perl(Path::Iterator::Rule)
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Path-Tiny-Rule-0.01-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(Path::Tiny::Rule) = 0.01
      1 perl-Path-Tiny-Rule = 0.01-1.fc29
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Path-Tiny-Rule-0.01-1.fc29.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=26163621). Ok.

This package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Jason Tibbitts 2018-04-04 21:01:04 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Path-Tiny-Rule