Bug 1564272

Summary: Review Request: golang-github-klauspost-compress - Optimized compression packages
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-11 22:18:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1377262, 1561757    

Description Dominik 'Rathann' Mierzejewski 2018-04-05 21:17:48 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-klauspost-compress/golang-github-klauspost-compress.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-klauspost-compress/golang-github-klauspost-compress-1.2.1-1.fc27.src.rpm
Description:
This package is based on an optimized Deflate function, which is used by
gzip/zip/zlib packages.

It offers slightly better compression at lower compression settings, and up to
3x faster encoding at highest compression level.

Fedora Account System Username: rathann

Comment 1 Robert-André Mauchin 🐧 2018-04-06 10:02:48 UTC
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines

 - Fix the line encodings for:

golang-github-klauspost-compress-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-klauspost-compress-devel/README.md
golang-github-klauspost-compress-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/gocode/src/github.com/klauspost/compress/README.md


Package approved.

Comment 2 Gwyn Ciesla 2018-04-09 13:05:12 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-klauspost-compress

Comment 3 Dominik 'Rathann' Mierzejewski 2018-04-11 22:18:21 UTC
I had to make it archful due to the use of assembly on x86_64 (noarch package came out different on x86_64), but finally imported and built for rawhide. Thanks for the review.