Bug 1564461

Summary:	gfapi: fix a couple of minor issues
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.0	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.0.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1564235	Environment:
Last Closed:	2018-05-07 15:15:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1564235
Bug Blocks:	1559547

Description Kaleb KEITHLEY 2018-04-06 10:54:24 UTC

+++ This bug was initially created as a clone of Bug #1564235 +++

Description of problem:

Over time a couple of minor issues have crept into gfapi

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-04-05 15:11:40 EDT ---

REVIEW: https://review.gluster.org/19828 (gfapi: fix a couple of minor issues) posted (#1) for review on master by Kaleb KEITHLEY

--- Additional comment from Worker Ant on 2018-04-06 03:00:57 EDT ---

COMMIT: https://review.gluster.org/19828 committed in master by "Kaleb KEITHLEY" <kkeithle> with a commit message- gfapi: fix a couple of minor issues

duplicatation of exported functions in gfapi.map. Only the newest one
is needed. Both the legacy and current symbols are exported.

glfs_io_cbk34 typedef should not be in a public header file. The old
application was compiled with the original glfs_io_cbk. Outside of
libgfapi, nothing now uses/needs this old typedef, move it into the
C file that needs it.

Similarly glfs_realpath34() decl should not be in glfs.h. Period. Old
applications were compiled with the then glfs_realpath() decl and
linked with glfs_realpath@@GFAPI_3_4.0. New applications should only
call glfs_realpath() and it will be linked to the new/current
glfs_realpath().

Change-Id: Icd5b0c9e9b68f0c133f14447b09ace35f33dbab2
fixes: bz#1564235
Signed-off-by: Kaleb S. KEITHLEY <kkeithle>

Comment 1 Worker Ant 2018-04-06 12:58:52 UTC

REVIEW: https://review.gluster.org/19832 (gfapi: fix a couple of minor issues) posted (#1) for review on release-4.0 by Kaleb KEITHLEY

Comment 2 Worker Ant 2018-04-09 12:49:08 UTC

COMMIT: https://review.gluster.org/19832 committed in release-4.0 by "Kaleb KEITHLEY" <kkeithle> with a commit message- gfapi: fix a couple of minor issues

duplicatation of exported functions in gfapi.map. Only the newest one
is needed. Both the legacy and current symbols are exported.

glfs_realpath34() decl should not be in glfs.h. Period. Old
applications were compiled with the then glfs_realpath() decl and
linked with glfs_realpath@@GFAPI_3_4.0. New applications should only
call glfs_realpath() and it will be linked to the new/current
glfs_realpath().

master: https://review.gluster.org/19828
master: bz#1564235

Change-Id: Icd5b0c9e9b68f0c133f14447b09ace35f33dbab2
BUG: 1564461
fixes: bz#1564461
Signed-off-by: Kaleb S. KEITHLEY <kkeithle>

Comment 3 Shyamsundar 2018-05-07 15:15:28 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.2, please open a new bug report.

glusterfs-4.0.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-April/000097.html
[2] https://www.gluster.org/pipermail/gluster-users/