Bug 1565002

Summary:	Check vdsmd status before starting rpm upgrade
Product:	[oVirt] vdsm	Reporter:	Yaniv Bronhaim <ybronhei>
Component:	Packaging.rpm	Assignee:	Martin Perina <mperina>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavol Brilla <pbrilla>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.20.23	CC:	bugs, lsvaty, nsoffer
Target Milestone:	ovirt-4.2.4	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vdsm-4.20.28-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-26 08:39:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yaniv Bronhaim 2018-04-09 06:38:13 UTC

Description of problem:
In bug #1557735 we recognized case where vdsmd is being restarted during upgrade and fails to start. We are not sure exactly if this flow is right or wrong, but in case it happens vdsmd stays down after upgrade. In this bugzilla we add logic to remember vdsmd status before starting the upgrade and re-establish same state after upgrade is done. 
This change is done as part of the rpm spec and related to vdsm packaging.

Version-Release number of selected component (if applicable):
v4.20.23

Actual results:
Vdsm stays with same status after upgrade (stopped or started)

Additional info:
This flow requires verification for upgrades scenarios to latest vdsm build

Comment 1 Yaniv Kaul 2018-04-10 13:57:13 UTC

Severity?

Comment 2 Yaniv Bronhaim 2018-04-15 09:03:41 UTC

We don't have regressions so far. It will be critical if vdsm introduces new config values, but as far as 4.2 we don't have it between recent versions.

Comment 4 Pavol Brilla 2018-06-25 19:46:47 UTC

3.6 -> 4.2.4  upgrade OK

4.1 -> 4.2.4 upgrade OK

( tested with stopped and also with started vdsm - status was OK in both cases )

Comment 5 Sandro Bonazzola 2018-06-26 08:39:19 UTC

This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.